Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1375233004: Roll chromium_revision 8cf53d6..681f0cd (351112:351698) (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
marpan2
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision 8cf53d6..681f0cd (351112:351698) The GN changes in https://chromium.googlesource.com/chromium/src/+/7a73be6eb4963662a1e9455dcdab0d5130324901 broke libvpx, so a fix in https://codereview.chromium.org/1368223002 was needed to unblock this roll. Relevant changes: * src/buildtools: 8d89c1b..0c88009 * src/third_party/boringssl/src: 4c60d35..8c9b878 * src/third_party/libvpx_new/source/libvpx: 90a109f..7d28d12 * src/third_party/libyuv: 62c49dc..d039ad6 * src/third_party/openmax_dl: 2eb98d8..37b900c Details: https://chromium.googlesource.com/chromium/src/+/8cf53d6..681f0cd/DEPS Clang version was not updated in this roll. TBR=marpan@webrtc.org Committed: https://crrev.com/edba998cf16f500e258d25149584caa1b2ca9af6 Cr-Commit-Position: refs/heads/master@{#10129}

Patch Set 1 #

Patch Set 2 : Updated to 681f0cd52075b890849f54b873f075d6cc92a4ef (#351698) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
kjellander_webrtc
Should go green with Johann's fix now.
5 years, 2 months ago (2015-10-01 07:18:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375233004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375233004/20001
5 years, 2 months ago (2015-10-01 07:18:39 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-01 07:18:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375233004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375233004/20001
5 years, 2 months ago (2015-10-01 07:30:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 08:17:33 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 08:17:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/edba998cf16f500e258d25149584caa1b2ca9af6
Cr-Commit-Position: refs/heads/master@{#10129}

Powered by Google App Engine
This is Rietveld 408576698