Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374673003: Move sent key frame stats to send_statistics_proxy class. (Closed)

Created:
5 years, 2 months ago by åsapersson
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move sent key frame stats to send_statistics_proxy class. BUG= Committed: https://crrev.com/dec5ebf10614115d6f2561c65f0cce3fd80ecfd2 Cr-Commit-Position: refs/heads/master@{#10166}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : address comments #

Total comments: 4

Patch Set 4 : removed functions (SentFrameCount, SendCodecStatistics) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -60 lines) Patch
M webrtc/modules/video_coding/main/interface/video_coding.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/main/source/media_optimization.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/media_optimization.cc View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_coding_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/video_coding_impl.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 2 3 chunks +32 lines, -0 lines 0 comments Download
M webrtc/video_engine/vie_encoder.h View 1 2 3 3 chunks +0 lines, -5 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 2 3 3 chunks +1 line, -32 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
åsapersson
5 years, 2 months ago (2015-09-28 11:57:33 UTC) #2
pbos-webrtc
https://codereview.webrtc.org/1374673003/diff/1/webrtc/video/send_statistics_proxy.cc File webrtc/video/send_statistics_proxy.cc (right): https://codereview.webrtc.org/1374673003/diff/1/webrtc/video/send_statistics_proxy.cc#newcode171 webrtc/video/send_statistics_proxy.cc:171: if (encoded_image._length > 0) Can we make sure that ...
5 years, 2 months ago (2015-09-28 12:10:34 UTC) #3
åsapersson
https://codereview.webrtc.org/1374673003/diff/1/webrtc/video/send_statistics_proxy.cc File webrtc/video/send_statistics_proxy.cc (right): https://codereview.webrtc.org/1374673003/diff/1/webrtc/video/send_statistics_proxy.cc#newcode171 webrtc/video/send_statistics_proxy.cc:171: if (encoded_image._length > 0) On 2015/09/28 12:10:34, pbos-webrtc wrote: ...
5 years, 2 months ago (2015-09-28 13:14:26 UTC) #4
pbos-webrtc
https://codereview.webrtc.org/1374673003/diff/40001/webrtc/video/send_statistics_proxy.cc File webrtc/video/send_statistics_proxy.cc (right): https://codereview.webrtc.org/1374673003/diff/40001/webrtc/video/send_statistics_proxy.cc#newcode302 webrtc/video/send_statistics_proxy.cc:302: int min_required_samples, float multiplier) const { denominator https://codereview.webrtc.org/1374673003/diff/40001/webrtc/video/send_statistics_proxy.h File ...
5 years, 2 months ago (2015-09-28 13:50:12 UTC) #5
åsapersson
https://codereview.webrtc.org/1374673003/diff/40001/webrtc/video_engine/vie_encoder.cc File webrtc/video_engine/vie_encoder.cc (left): https://codereview.webrtc.org/1374673003/diff/40001/webrtc/video_engine/vie_encoder.cc#oldcode188 webrtc/video_engine/vie_encoder.cc:188: if (vcm_->SentFrameCount(frames) != VCM_OK) { On 2015/09/28 13:50:12, pbos-webrtc ...
5 years, 2 months ago (2015-09-28 15:21:03 UTC) #7
pbos-webrtc
lgtm
5 years, 2 months ago (2015-09-28 15:22:43 UTC) #8
stefan-webrtc
lgtm
5 years, 2 months ago (2015-09-30 10:37:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374673003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374673003/60001
5 years, 2 months ago (2015-10-05 08:31:01 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-05 09:36:22 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 09:36:25 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/dec5ebf10614115d6f2561c65f0cce3fd80ecfd2
Cr-Commit-Position: refs/heads/master@{#10166}

Powered by Google App Engine
This is Rietveld 408576698