Added functions on libjingle API to start and stop the recording of an RtcEventLog.

webrtc/call/rtc_event_log.h

Index: webrtc/call/rtc_event_log.h
diff --git a/webrtc/call/rtc_event_log.h b/webrtc/call/rtc_event_log.h
index a4b7cadadb7c3970865380866cbf320805773175..8bff922fb4369102d67366bf7695b096a9088326 100644
--- a/webrtc/call/rtc_event_log.h
+++ b/webrtc/call/rtc_event_log.h
@@ -13,6 +13,7 @@
 
 #include <string>
 
+#include "webrtc/base/platform_file.h"
 #include "webrtc/base/scoped_ptr.h"
 #include "webrtc/video_receive_stream.h"
 #include "webrtc/video_send_stream.h"
@@ -41,6 +42,11 @@ class RtcEventLog {
   // If the file cannot be opened, the RtcEventLog will not start logging.
   virtual void StartLogging(const std::string& file_name, int duration_ms) = 0;
 
+  // Starts logging until either the 10 minute timer runs out or the StopLogging
+  // function is called. The RtcEventLog takes ownership of the supplied
+  // rtc::PlatformFile.
+  virtual bool StartLogging(rtc::PlatformFile& log_file) = 0;

[the sun, 2015/10/14 13:36:16]

Are we lacking a unit test for this function?

[the sun, 2015/10/14 13:36:16]

Send this in by value instead. Non-const references are banned btw (use pointers
instead, for mutable parameters).

[ivoc, 2015/10/15 15:36:14]

There is indeed no unit test for this one, however the other StartLogging
function is tested pretty extensively (and is very similar to this one). I
looked into this a little further, and it seems not trivial to add a unit test
for this one, as there seems to be no way to actually open an rtc::Platformfile
in webrtc/base/platform_file.h. Adding a function to do that would be possible,
but seems a bit outside of the scope of this CL. Do you agree?

[ivoc, 2015/10/15 15:36:14]

Done.

[the sun, 2015/10/15 16:15:14]

sgtm

+
   virtual void StopLogging() = 0;
 
   // Logs configuration information for webrtc::VideoReceiveStream