Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: webrtc/call/rtc_event_log.h

Issue 1374253002: Added functions on libjingle API to start and stop the recording of an RtcEventLog. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: RtcEventLog takes ownership of the rtc::PlatformFile. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/rtc_event_log.h
diff --git a/webrtc/call/rtc_event_log.h b/webrtc/call/rtc_event_log.h
index a4b7cadadb7c3970865380866cbf320805773175..a53b2ed56c8a9e62eb1c5768452c41ad95711023 100644
--- a/webrtc/call/rtc_event_log.h
+++ b/webrtc/call/rtc_event_log.h
@@ -11,8 +11,11 @@
#ifndef WEBRTC_CALL_RTC_EVENT_LOG_H_
#define WEBRTC_CALL_RTC_EVENT_LOG_H_
+#include <stdio.h>
+
#include <string>
+#include "webrtc/base/platform_file.h"
#include "webrtc/base/scoped_ptr.h"
#include "webrtc/video_receive_stream.h"
#include "webrtc/video_send_stream.h"
@@ -41,6 +44,16 @@ class RtcEventLog {
// If the file cannot be opened, the RtcEventLog will not start logging.
virtual void StartLogging(const std::string& file_name, int duration_ms) = 0;
+ // Starts logging until either the 10 minute timer runs out or the StopLogging
+ // function is called. This function uses an already opened file pointer, and
+ // will return 0 on success.
+ virtual int StartLogging(FILE* log_file) = 0;
the sun 2015/10/14 09:29:09 Can this be removed? Together with the stdio.h inc
ivoc 2015/10/14 12:23:47 Done and Done.
+
+ // Starts logging until either the 10 minute timer runs out or the StopLogging
+ // function is called. The RtcEventLog takes ownership of the supplied
+ // rtc::PlatformFile.
+ virtual int StartLogging(rtc::PlatformFile& log_file) = 0;
the sun 2015/10/14 09:29:09 Why doesn't this function return a bool?
ivoc 2015/10/14 12:23:47 I don't remember the reason, but I agree that bool
+
virtual void StopLogging() = 0;
// Logs configuration information for webrtc::VideoReceiveStream

Powered by Google App Engine
This is Rietveld 408576698