Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: talk/media/webrtc/webrtcvoiceengine.cc

Issue 1374253002: Added functions on libjingle API to start and stop the recording of an RtcEventLog. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: RtcEventLog takes ownership of the rtc::PlatformFile. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/webrtc/webrtcvoiceengine.cc
diff --git a/talk/media/webrtc/webrtcvoiceengine.cc b/talk/media/webrtc/webrtcvoiceengine.cc
index 54fac221d8fb7d6d829f606e8ab5f9897dc2469a..17785a09c4b93d01e3393d37d9668cee26c56cab 100644
--- a/talk/media/webrtc/webrtcvoiceengine.cc
+++ b/talk/media/webrtc/webrtcvoiceengine.cc
@@ -50,6 +50,7 @@
#include "webrtc/base/logging.h"
#include "webrtc/base/stringencode.h"
#include "webrtc/base/stringutils.h"
+#include "webrtc/call/rtc_event_log.h"
#include "webrtc/common.h"
#include "webrtc/modules/audio_processing/include/audio_processing.h"
@@ -1276,6 +1277,21 @@ void WebRtcVoiceEngine::StopAecDump() {
}
}
+bool WebRtcVoiceEngine::StartRtcEventLog(rtc::PlatformFile file) {
+ if (voe_wrapper_->codec()->GetEventLog()->StartLogging(file) != 0) {
+ LOG_RTCERR0(StartLogging);
+ if (!rtc::ClosePlatformFile(file)) {
the sun 2015/10/14 09:29:09 RtcEventLogImpl::StartLogging() takes ownership of
ivoc 2015/10/14 12:23:47 Good point, removed.
+ LOG(LS_WARNING) << "Could not close file.";
+ }
+ return false;
+ }
+ return true;
+}
+
+void WebRtcVoiceEngine::StopRtcEventLog() {
+ voe_wrapper_->codec()->GetEventLog()->StopLogging();
+}
+
int WebRtcVoiceEngine::CreateVoiceChannel(VoEWrapper* voice_engine_wrapper) {
return voice_engine_wrapper->base()->CreateChannel(voe_config_);
}

Powered by Google App Engine
This is Rietveld 408576698