Added functions on libjingle API to start and stop the recording of an RtcEventLog.

webrtc/call/rtc_event_log.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_CALL_RTC_EVENT_LOG_H_
 #define WEBRTC_CALL_RTC_EVENT_LOG_H_
 
 #include <string>
 
+#include "webrtc/base/platform_file.h"
 #include "webrtc/base/scoped_ptr.h"
 #include "webrtc/video_receive_stream.h"
 #include "webrtc/video_send_stream.h"
 
 namespace webrtc {
 
 // Forward declaration of storage class that is automatically generated from
 // the protobuf file.
 namespace rtclog {
 class EventStream;
 }  // namespace rtclog
 
 class RtcEventLogImpl;
 
 enum class MediaType;
 
 class RtcEventLog {
  public:
   virtual ~RtcEventLog() {}
 
   static rtc::scoped_ptr<RtcEventLog> Create();
 
   // Starts logging for the specified duration to the specified file.
   // The logging will stop automatically after the specified duration.
   // If the file already exists it will be overwritten.
   // If the file cannot be opened, the RtcEventLog will not start logging.
   virtual void StartLogging(const std::string& file_name, int duration_ms) = 0;
 
+  // Starts logging until either the 10 minute timer runs out or the StopLogging
+  // function is called. The RtcEventLog takes ownership of the supplied
+  // rtc::PlatformFile.
+  virtual bool StartLogging(rtc::PlatformFile& log_file) = 0;

[the sun, 2015/10/14 13:36:16]

Are we lacking a unit test for this function?

[the sun, 2015/10/14 13:36:16]

Send this in by value instead. Non-const references are banned btw (use pointers
instead, for mutable parameters).

[ivoc, 2015/10/15 15:36:14]

There is indeed no unit test for this one, however the other StartLogging
function is tested pretty extensively (and is very similar to this one). I
looked into this a little further, and it seems not trivial to add a unit test
for this one, as there seems to be no way to actually open an rtc::Platformfile
in webrtc/base/platform_file.h. Adding a function to do that would be possible,
but seems a bit outside of the scope of this CL. Do you agree?

[ivoc, 2015/10/15 15:36:14]

Done.

[the sun, 2015/10/15 16:15:14]

sgtm

+
   virtual void StopLogging() = 0;
 
   // Logs configuration information for webrtc::VideoReceiveStream
   virtual void LogVideoReceiveStreamConfig(
       const webrtc::VideoReceiveStream::Config& config) = 0;
 
   // Logs configuration information for webrtc::VideoSendStream
   virtual void LogVideoSendStreamConfig(
       const webrtc::VideoSendStream::Config& config) = 0;
 
@@ skipping 15 matching lines @@
 
   // Reads an RtcEventLog file and returns true when reading was successful.
   // The result is stored in the given EventStream object.
   static bool ParseRtcEventLog(const std::string& file_name,
                                rtclog::EventStream* result);
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_CALL_RTC_EVENT_LOG_H_