Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1374253002: Added functions on libjingle API to start and stop the recording of an RtcEventLog. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comments from the sun. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 601 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 CreateAudioTrack(const std::string& label, 612 CreateAudioTrack(const std::string& label,
613 AudioSourceInterface* source) = 0; 613 AudioSourceInterface* source) = 0;
614 614
615 // Starts AEC dump using existing file. Takes ownership of |file| and passes 615 // Starts AEC dump using existing file. Takes ownership of |file| and passes
616 // it on to VoiceEngine (via other objects) immediately, which will take 616 // it on to VoiceEngine (via other objects) immediately, which will take
617 // the ownerhip. If the operation fails, the file will be closed. 617 // the ownerhip. If the operation fails, the file will be closed.
618 // TODO(grunell): Remove when Chromium has started to use AEC in each source. 618 // TODO(grunell): Remove when Chromium has started to use AEC in each source.
619 // http://crbug.com/264611. 619 // http://crbug.com/264611.
620 virtual bool StartAecDump(rtc::PlatformFile file) = 0; 620 virtual bool StartAecDump(rtc::PlatformFile file) = 0;
621 621
622 // Starts RtcEventLog using existing file. Takes ownership of |file| and
623 // passes it on to VoiceEngine, which will take the ownership. If the
624 // operation fails the file will be closed. The logging will stop
625 // automatically after 10 minutes have passed, or when the StopRtcEventLog
626 // function is called.
627 // This function as well as the StopRtcEventLog don't really belong on this
628 // interface, this is a temporary solution until we move the logging object
629 // from inside voice engine to webrtc::Call, which will happen when the VoE
630 // restructuring effort is further along.
631 // TODO(ivoc): Move this into being:
632 // PeerConnection => MediaController => webrtc::Call.
633 virtual bool StartRtcEventLog(rtc::PlatformFile file) = 0;
634
635 // Stops logging the RtcEventLog.
636 virtual void StopRtcEventLog() = 0;
637
622 protected: 638 protected:
623 // Dtor and ctor protected as objects shouldn't be created or deleted via 639 // Dtor and ctor protected as objects shouldn't be created or deleted via
624 // this interface. 640 // this interface.
625 PeerConnectionFactoryInterface() {} 641 PeerConnectionFactoryInterface() {}
626 ~PeerConnectionFactoryInterface() {} // NOLINT 642 ~PeerConnectionFactoryInterface() {} // NOLINT
627 }; 643 };
628 644
629 // Create a new instance of PeerConnectionFactoryInterface. 645 // Create a new instance of PeerConnectionFactoryInterface.
630 rtc::scoped_refptr<PeerConnectionFactoryInterface> 646 rtc::scoped_refptr<PeerConnectionFactoryInterface>
631 CreatePeerConnectionFactory(); 647 CreatePeerConnectionFactory();
632 648
633 // Create a new instance of PeerConnectionFactoryInterface. 649 // Create a new instance of PeerConnectionFactoryInterface.
634 // Ownership of |factory|, |default_adm|, and optionally |encoder_factory| and 650 // Ownership of |factory|, |default_adm|, and optionally |encoder_factory| and
635 // |decoder_factory| transferred to the returned factory. 651 // |decoder_factory| transferred to the returned factory.
636 rtc::scoped_refptr<PeerConnectionFactoryInterface> 652 rtc::scoped_refptr<PeerConnectionFactoryInterface>
637 CreatePeerConnectionFactory( 653 CreatePeerConnectionFactory(
638 rtc::Thread* worker_thread, 654 rtc::Thread* worker_thread,
639 rtc::Thread* signaling_thread, 655 rtc::Thread* signaling_thread,
640 AudioDeviceModule* default_adm, 656 AudioDeviceModule* default_adm,
641 cricket::WebRtcVideoEncoderFactory* encoder_factory, 657 cricket::WebRtcVideoEncoderFactory* encoder_factory,
642 cricket::WebRtcVideoDecoderFactory* decoder_factory); 658 cricket::WebRtcVideoDecoderFactory* decoder_factory);
643 659
644 } // namespace webrtc 660 } // namespace webrtc
645 661
646 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_ 662 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698