Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 1374153003: Android MediaDecoder: Use frame pool to avoid allocations for non-surface decoding (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android MediaDecoder: Use frame pool to avoid allocations for non-surface decoding BUG=webrtc:4993 TEST=To test non-surface path, set 'use_surface_ = false' in androidmediadecoder_jni.cc. R=perkj@webrtc.org Committed: https://crrev.com/bbda54e6fa3108451fbe83a6b55c30a0f443b532 Cr-Commit-Position: refs/heads/master@{#10116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -40 lines) Patch
M talk/app/webrtc/java/jni/androidmediadecoder_jni.cc View 7 chunks +43 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 2 months ago (2015-09-30 06:26:19 UTC) #2
perkj_webrtc
code looks good. But please write how you test this in the description since it ...
5 years, 2 months ago (2015-09-30 09:57:43 UTC) #3
perkj_webrtc
On 2015/09/30 09:57:43, perkj1 wrote: > code looks good. > But please write how you ...
5 years, 2 months ago (2015-09-30 12:16:30 UTC) #4
magjed_webrtc
Committed patchset #1 (id:1) manually as bbda54e6fa3108451fbe83a6b55c30a0f443b532 (presubmit successful).
5 years, 2 months ago (2015-09-30 14:07:02 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 14:07:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbda54e6fa3108451fbe83a6b55c30a0f443b532
Cr-Commit-Position: refs/heads/master@{#10116}

Powered by Google App Engine
This is Rietveld 408576698