Unify newapi::RtcpMode and RTCPMethod.

webrtc/common_types.h

Index: webrtc/common_types.h
diff --git a/webrtc/common_types.h b/webrtc/common_types.h
index 9b730a13cbbea99b163a86681345339b62e56bac..44ccbc884dede33d8f4806cee9d0d7adb0acf614 100644
--- a/webrtc/common_types.h
+++ b/webrtc/common_types.h
@@ -893,6 +893,11 @@ class StreamDataCountersCallback {
   virtual void DataCountersUpdated(const StreamDataCounters& counters,
                                    uint32_t ssrc) = 0;
 };
+
+// RTCP mode to use. Compound mode is described by RFC 4585 and reduced-size
+// RTCP mode is described by RFC 5506.
+enum class RtcpMode { OFF, COMPOUND, REDUCED_SIZE };

[stefan-webrtc, 2015/09/30 09:58:13]

I would say it's more common to use kOff, kCompound, etc. in WebRTC code. I
don't have a strong opinion myself, but I am opposed to having a mix...

Also, isn't it strange to expose the option OFF in the API, and then DCHECK on
that no one uses that setting? Seems like that should be an internal option in
that case?

[pbos-webrtc, 2015/09/30 10:16:13]

Changed to kConstant, that's my impression as well.

Yeah, a bit, but I think it's preferable to having to convert between types for
these as soon as they go into/out of the RTP module. Now it's one DCHECK.

+
 }  // namespace webrtc
 
 #endif  // WEBRTC_COMMON_TYPES_H_