Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

Issue 1373903003: Unify newapi::RtcpMode and RTCPMethod. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: enum class Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 ModuleRtpRtcpImpl* module; 71 ModuleRtpRtcpImpl* module;
72 }; 72 };
73 73
74 RTCPSender(bool audio, 74 RTCPSender(bool audio,
75 Clock* clock, 75 Clock* clock,
76 ReceiveStatistics* receive_statistics, 76 ReceiveStatistics* receive_statistics,
77 RtcpPacketTypeCounterObserver* packet_type_counter_observer, 77 RtcpPacketTypeCounterObserver* packet_type_counter_observer,
78 Transport* outgoing_transport); 78 Transport* outgoing_transport);
79 virtual ~RTCPSender(); 79 virtual ~RTCPSender();
80 80
81 RTCPMethod Status() const; 81 RtcpMode Status() const;
82 void SetRTCPStatus(RTCPMethod method); 82 void SetRTCPStatus(RtcpMode method);
83 83
84 bool Sending() const; 84 bool Sending() const;
85 int32_t SetSendingStatus(const FeedbackState& feedback_state, 85 int32_t SetSendingStatus(const FeedbackState& feedback_state,
86 bool enabled); // combine the functions 86 bool enabled); // combine the functions
87 87
88 int32_t SetNackStatus(bool enable); 88 int32_t SetNackStatus(bool enable);
89 89
90 void SetStartTimestamp(uint32_t start_timestamp); 90 void SetStartTimestamp(uint32_t start_timestamp);
91 91
92 void SetLastRtpTime(uint32_t rtp_timestamp, int64_t capture_time_ms); 92 void SetLastRtpTime(uint32_t rtp_timestamp, int64_t capture_time_ms);
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 BuildResult BuildNACK(RtcpContext* context) 218 BuildResult BuildNACK(RtcpContext* context)
219 EXCLUSIVE_LOCKS_REQUIRED(critical_section_rtcp_sender_); 219 EXCLUSIVE_LOCKS_REQUIRED(critical_section_rtcp_sender_);
220 BuildResult BuildReceiverReferenceTime(RtcpContext* context) 220 BuildResult BuildReceiverReferenceTime(RtcpContext* context)
221 EXCLUSIVE_LOCKS_REQUIRED(critical_section_rtcp_sender_); 221 EXCLUSIVE_LOCKS_REQUIRED(critical_section_rtcp_sender_);
222 BuildResult BuildDlrr(RtcpContext* context) 222 BuildResult BuildDlrr(RtcpContext* context)
223 EXCLUSIVE_LOCKS_REQUIRED(critical_section_rtcp_sender_); 223 EXCLUSIVE_LOCKS_REQUIRED(critical_section_rtcp_sender_);
224 224
225 private: 225 private:
226 const bool audio_; 226 const bool audio_;
227 Clock* const clock_; 227 Clock* const clock_;
228 RTCPMethod method_ GUARDED_BY(critical_section_rtcp_sender_); 228 RtcpMode method_ GUARDED_BY(critical_section_rtcp_sender_);
229 229
230 Transport* const transport_; 230 Transport* const transport_;
231 231
232 rtc::scoped_ptr<CriticalSectionWrapper> critical_section_rtcp_sender_; 232 rtc::scoped_ptr<CriticalSectionWrapper> critical_section_rtcp_sender_;
233 bool using_nack_ GUARDED_BY(critical_section_rtcp_sender_); 233 bool using_nack_ GUARDED_BY(critical_section_rtcp_sender_);
234 bool sending_ GUARDED_BY(critical_section_rtcp_sender_); 234 bool sending_ GUARDED_BY(critical_section_rtcp_sender_);
235 bool remb_enabled_ GUARDED_BY(critical_section_rtcp_sender_); 235 bool remb_enabled_ GUARDED_BY(critical_section_rtcp_sender_);
236 236
237 int64_t next_time_to_send_rtcp_ GUARDED_BY(critical_section_rtcp_sender_); 237 int64_t next_time_to_send_rtcp_ GUARDED_BY(critical_section_rtcp_sender_);
238 238
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 std::set<ReportFlag> report_flags_ GUARDED_BY(critical_section_rtcp_sender_); 317 std::set<ReportFlag> report_flags_ GUARDED_BY(critical_section_rtcp_sender_);
318 318
319 typedef BuildResult (RTCPSender::*Builder)(RtcpContext*); 319 typedef BuildResult (RTCPSender::*Builder)(RtcpContext*);
320 std::map<RTCPPacketType, Builder> builders_; 320 std::map<RTCPPacketType, Builder> builders_;
321 321
322 class PacketBuiltCallback; 322 class PacketBuiltCallback;
323 }; 323 };
324 } // namespace webrtc 324 } // namespace webrtc
325 325
326 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_SENDER_H_ 326 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_SENDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698