Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1373513002: Update isolate.gypi to support Swarming + move .isolate files (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update isolate.gypi to support Swarming + move .isolate files This updates the isolate.gypi copies we have to maintain in our code repo to Chromium's revision 310ea93. The changes about generating .isolated.gen.json files are needed to support running with Swarming (https://www.chromium.org/developers/testing/isolated-testing) Since isolated testing is now using a new launch script in tools: isolate_driver.py, that's added to our links script. In order to use isolate_driver.py, the .isolate files must be in the same directory as the test_name_run target is defined, which meant I had to move around some of the isolate files and targets below webrtc/modules. BUG=497757 R=maruel@chromium.org TBR=henrik.lundin@webrtc.org, mflodman@webrtc.org, niklas.enbom@webrtc.org TESTED=Clobbered trybots: git cl try -c --bot=linux_compile_rel --bot=mac_compile_rel --bot=win_compile_rel --bot=android_compile_rel --bot=ios_rel -m tryserver.webrtc Committed: https://crrev.com/d6d27e7340bca1598973e2197cf08d79ce9aeb04 Cr-Commit-Position: refs/heads/master@{#10081}

Patch Set 1 #

Patch Set 2 : Moved .isolate files and _run targets to avoid hitting assert #

Patch Set 3 : Updated location in webrtc/build/android/test_runner.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -212 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M setup_links.py View 1 chunk +1 line, -0 lines 0 comments Download
M talk/build/isolate.gypi View 2 chunks +49 lines, -17 lines 0 comments Download
M webrtc/build/android/test_runner.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/isolate.gypi View 2 chunks +49 lines, -16 lines 0 comments Download
A + webrtc/modules/audio_codec_speed_tests.isolate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/modules/audio_coding/audio_codec_speed_tests.isolate View 1 1 chunk +0 lines, -33 lines 0 comments Download
M webrtc/modules/audio_coding/audio_coding_tests.gypi View 1 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/audio_decoder_unittests.isolate View 1 1 chunk +0 lines, -31 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 1 chunk +0 lines, -17 lines 0 comments Download
A + webrtc/modules/audio_decoder_unittests.isolate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M webrtc/modules/audio_device/audio_device.gypi View 1 1 chunk +0 lines, -19 lines 0 comments Download
D webrtc/modules/audio_device/audio_device_tests.isolate View 1 1 chunk +0 lines, -23 lines 0 comments Download
A + webrtc/modules/audio_device_tests.isolate View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 2 chunks +52 lines, -0 lines 0 comments Download
M webrtc/modules/video_render/video_render.gypi View 1 1 chunk +0 lines, -19 lines 0 comments Download
D webrtc/modules/video_render/video_render_tests.isolate View 1 1 chunk +0 lines, -23 lines 0 comments Download
A + webrtc/modules/video_render_tests.isolate View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
kjellander_webrtc
Without the moving of targets and .isolate files in PS#2 we hit the assert in ...
5 years, 2 months ago (2015-09-25 13:04:44 UTC) #2
M-A Ruel
On 2015/09/25 13:04:44, kjellander (webrtc) wrote: > Without the moving of targets and .isolate files ...
5 years, 2 months ago (2015-09-25 13:21:37 UTC) #3
M-A Ruel
lgtm
5 years, 2 months ago (2015-09-25 13:22:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373513002/20001
5 years, 2 months ago (2015-09-25 17:25:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/965)
5 years, 2 months ago (2015-09-25 17:29:34 UTC) #8
kjellander_webrtc
TBRing a few WebRTC folks since the OWNERS rules we have doesn't seem to be ...
5 years, 2 months ago (2015-09-25 17:40:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373513002/20001
5 years, 2 months ago (2015-09-25 17:43:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
5 years, 2 months ago (2015-09-25 19:25:14 UTC) #14
kjellander_webrtc
Committed patchset #3 (id:40001) manually as d6d27e7340bca1598973e2197cf08d79ce9aeb04 (presubmit successful).
5 years, 2 months ago (2015-09-25 20:19:28 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/d6d27e7340bca1598973e2197cf08d79ce9aeb04 Cr-Commit-Position: refs/heads/master@{#10081}
5 years, 2 months ago (2015-09-25 20:19:31 UTC) #16
hlundin-webrtc
5 years, 2 months ago (2015-09-28 14:44:00 UTC) #17
Message was sent while issue was closed.
webrtc/modules/audio_cod*: lgtm

Powered by Google App Engine
This is Rietveld 408576698