JavaVideoRendererWrapper: Use jlongFromPointer() to convert frame pointer to jlong

JavaVideoRendererWrapper: Use jlongFromPointer() to convert frame pointer to jlong

The purpose of this CL is to use jlongFromPointer() for converting frame pointers to jlong instead of implicit casts which is not safe.

In order to respect constness, I had to make a small helper function for this.

BUG=webrtc:4993
R=perkj@webrtc.org

Committed: https://crrev.com/1d640e53bde26f6951e274a0837aeedb82f5ea3f
Cr-Commit-Position: refs/heads/master@{#10108}

[magjed_webrtc, 2015-09-29 11:27:46]

magjed@webrtc.org changed reviewers:
+ perkj@webrtc.org

[magjed_webrtc, 2015-09-29 11:28:40]

perkj - Please take a look.

[perkj_webrtc, 2015-09-29 12:56:04]

https://codereview.webrtc.org/1373233002/diff/1/talk/app/webrtc/java/jni/peer...
File talk/app/webrtc/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1373233002/diff/1/talk/app/webrtc/java/jni/peer...
talk/app/webrtc/java/jni/peerconnection_jni.cc:819: strides, planes,
javaShallowCopy(frame));
Even if this is shallow, it allocates memory. Who owns and deletes that if you
make a copy? WebRtcVideoFrame::Copy.

[magjed_webrtc, 2015-09-29 13:16:17]

https://codereview.webrtc.org/1373233002/diff/1/talk/app/webrtc/java/jni/peer...
File talk/app/webrtc/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1373233002/diff/1/talk/app/webrtc/java/jni/peer...
talk/app/webrtc/java/jni/peerconnection_jni.cc:819: strides, planes,
javaShallowCopy(frame));
On 2015/09/29 12:56:04, perkj1 wrote:
> Even if this is shallow, it allocates memory. Who owns and deletes that if you
> make a copy? WebRtcVideoFrame::Copy.

It's documented in the comment of javaShallowCopy() and above the j_callbacks
call. The memory is released when VideoRenderer.renderFrameDone() ->
VideoRenderer.releaseNativeFrame() is called.

[perkj_webrtc, 2015-09-29 14:26:25]

lgtm

[magjed_webrtc, 2015-09-29 14:33:29]

Committed patchset #1 (id:1) to pending queue manually as
1de3874406959328ce4207bd94f79cf9b3a21714 (presubmit successful).

[commit-bot: I haz the power, 2015-09-29 14:33:35]

Patchset 1 (id:??) landed as
https://crrev.com/1d640e53bde26f6951e274a0837aeedb82f5ea3f
Cr-Commit-Position: refs/heads/master@{#10108}