Android VideoCapturer: Send ByteBuffer instead of byte[]

talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java

 /*
  * libjingle
  * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 17 matching lines @@
 
 import android.hardware.Camera;
 import android.test.ActivityTestCase;
 import android.test.suitebuilder.annotation.SmallTest;
 import android.test.suitebuilder.annotation.MediumTest;
 import android.util.Size;
 
 import org.webrtc.CameraEnumerationAndroid.CaptureFormat;
 import org.webrtc.VideoRenderer.I420Frame;
 
+import java.nio.ByteBuffer;
 import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
 import java.util.concurrent.CountDownLatch;
 
 @SuppressWarnings("deprecation")
 public class VideoCapturerAndroidTest extends ActivityTestCase {
   static class RendererCallbacks implements VideoRenderer.Callbacks {
     private int framesRendered = 0;
@@ skipping 49 matching lines @@
 
     @Override
     public void OnCapturerStarted(boolean success) {
       synchronized (capturerStartLock) {
         captureStartResult = success;
         capturerStartLock.notify();
       }
     }
 
     @Override
-    public void OnFrameCaptured(byte[] frame, int length, int width, int height,
+    public void OnFrameCaptured(ByteBuffer frame, int width, int height,
         int rotation, long timeStamp) {
       synchronized (frameLock) {
         ++framesCaptured;
-        frameSize = length;
+        frameSize = frame.capacity();

[hbos, 2015/09/28 12:35:51]

Should limit() be used instead of capacity()?
Or maybe not if we are doing JNI magic with GetDirectBufferCapacity...?

[magjed_webrtc, 2015/09/28 14:42:42]

I know for sure that capacity() is exactly like previous |length|. I'm not sure
if limit() is set at all. We just send a byte[] to the camera, so I don't think
the marker in the ByteBuffer is touched at all.

         timestamps.add(timeStamp);
         frameLock.notify();
       }
     }
 
     @Override
     public void OnOutputFormatRequest(int width, int height, int fps) {}
 
     public boolean WaitForCapturerToStart() throws InterruptedException {
       synchronized (capturerStartLock) {
@@ skipping 327 matching lines @@
         }
       }
     });
     returnThread.start();
     returnThread.join();
 
     // Check that frames have successfully returned. This will cause |capturer| to be released.
     assertTrue(capturer.isReleased());
   }
 }