Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1370443003: Minor fix for improving logging of supported platform effects (Closed)

Created:
5 years, 3 months ago by henrika_webrtc
Modified:
5 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor fix for improving logging of supported platform effects BUG=NONE R=magjed@webrtc.org Committed: https://crrev.com/9236bb1e08f195b8a41296bf21f79ba8a72b92b9 Cr-Commit-Position: refs/heads/master@{#10053}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback from magjed@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -20 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java View 1 5 chunks +30 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
henrika_webrtc
Adding small change since I detected an issue on Samsung Galaxy S6.
5 years, 3 months ago (2015-09-24 12:32:04 UTC) #2
magjed_webrtc
lgtm % format nit https://codereview.webrtc.org/1370443003/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java (right): https://codereview.webrtc.org/1370443003/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java#newcode318 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java:318: (agc.getEnabled() ? "enabled" : "disabled") ...
5 years, 3 months ago (2015-09-24 12:47:40 UTC) #3
henrika_webrtc
Done. Thanks. https://codereview.webrtc.org/1370443003/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java (right): https://codereview.webrtc.org/1370443003/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java#newcode318 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java:318: (agc.getEnabled() ? "enabled" : "disabled") + On ...
5 years, 2 months ago (2015-09-24 13:57:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370443003/20001
5 years, 2 months ago (2015-09-24 13:58:20 UTC) #7
henrika_webrtc
Committed patchset #2 (id:20001) manually as 9236bb1e08f195b8a41296bf21f79ba8a72b92b9 (presubmit successful).
5 years, 2 months ago (2015-09-24 13:58:50 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-24 13:58:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9236bb1e08f195b8a41296bf21f79ba8a72b92b9
Cr-Commit-Position: refs/heads/master@{#10053}

Powered by Google App Engine
This is Rietveld 408576698