Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1370113005: Android VideoRendererGui: Make deep copy of incoming texture frames (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android VideoRendererGui: Make deep copy of incoming texture frames VideoRendererGui may need to render incoming frames multiple times. We currently call VideoRenderer.renderFrameDone() while we still hold references to the OES texture. This CL makes a deep copy of the OES texture before calling renderFrameDone(). This will truly release the dependency to the incoming frame, so that video textures sources can rely on the renderFrameDone() callback. This CL is a part of the plan in https://codereview.webrtc.org/1357923002/. The texture copy doesn't cause any measurable performance difference on a Nexus 5 using VideoRendererGui in a AppRTCDemo loopback call. BUG=webrtc:4993 TEST=Revert "Enable SurfaceViewRenderer for AppRTCDemo" https://codereview.webrtc.org/1356603004/ and try AppRTCDemo. R=perkj@webrtc.org Committed: https://crrev.com/bc0938e8e7db590b6c01f19e57a3418a9cd52523 Cr-Commit-Position: refs/heads/master@{#10157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -16 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 5 chunks +36 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 2 months ago (2015-10-02 14:43:05 UTC) #2
perkj_webrtc
On 2015/10/02 14:43:05, magjed_webrtc wrote: > perkj - Please take a look. lgtm
5 years, 2 months ago (2015-10-02 15:34:58 UTC) #3
magjed_webrtc
Committed patchset #1 (id:1) manually as bc0938e8e7db590b6c01f19e57a3418a9cd52523 (presubmit successful).
5 years, 2 months ago (2015-10-03 15:30:18 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-03 15:30:21 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc0938e8e7db590b6c01f19e57a3418a9cd52523
Cr-Commit-Position: refs/heads/master@{#10157}

Powered by Google App Engine
This is Rietveld 408576698