Android SurfaceViewRenderer: Enable hardware scaler

Android SurfaceViewRenderer: Enable hardware scaler

This CL enables the hardware scaler by calling SurfaceHoler.setFixedSize() in SurfaceViewRenderer. This gives a big reduction in GPU load for SurfaceViewRenderers with layout size > frame size. In an AppRTCDemo loopback call with 720p video this gives around 2x total GPU load reduction.

[magjed_webrtc, 2015-11-12 09:27:55]

Patchset #5 (id:80001) has been deleted

[magjed_webrtc, 2015-11-12 09:28:04]

Patchset #4 (id:60001) has been deleted

[magjed_webrtc, 2015-11-12 09:28:13]

Patchset #3 (id:40001) has been deleted

[magjed_webrtc, 2015-11-12 09:28:20]

Patchset #2 (id:20001) has been deleted

[magjed_webrtc, 2015-11-12 09:28:27]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2015-11-12 09:31:00]

Description was changed from

==========
Android SurfaceViewRenderer: Enable hardware scaler

This CL enables the hardware scaler by calling SurfaceHoler.setFixedSize() in
SurfaceViewRenderer.
==========

to

==========
Android SurfaceViewRenderer: Enable hardware scaler

This CL enables the hardware scaler by calling SurfaceHoler.setFixedSize() in
SurfaceViewRenderer. This gives a big reduction in GPU load for
SurfaceViewRenderers with layout size > frame size. In an AppRTCDemo loopback
call with 720p video this gives around 2x GPU load reduction.
==========

[magjed_webrtc, 2015-11-12 09:31:41]

Description was changed from

==========
Android SurfaceViewRenderer: Enable hardware scaler

This CL enables the hardware scaler by calling SurfaceHoler.setFixedSize() in
SurfaceViewRenderer. This gives a big reduction in GPU load for
SurfaceViewRenderers with layout size > frame size. In an AppRTCDemo loopback
call with 720p video this gives around 2x GPU load reduction.
==========

to

==========
Android SurfaceViewRenderer: Enable hardware scaler

This CL enables the hardware scaler by calling SurfaceHoler.setFixedSize() in
SurfaceViewRenderer. This gives a big reduction in GPU load for
SurfaceViewRenderers with layout size > frame size. In an AppRTCDemo loopback
call with 720p video this gives around 2x total GPU load reduction.
==========

[magjed_webrtc, 2015-11-12 09:31:59]

magjed@webrtc.org changed reviewers:
+ hbos@webrtc.org

[magjed_webrtc, 2015-11-12 09:32:09]

hbos - Please take a look.

[hbos, 2015-11-12 11:35:48]

First pass, mostly questions about the code since I don't know it too well

https://codereview.webrtc.org/1370063003/diff/100001/talk/app/webrtc/java/and...
File talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java (right):

https://codereview.webrtc.org/1370063003/diff/100001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java:62: private
static class LayoutConfiguration {
If two objects are considered equal in java they should produce the same
hashCode() so when overriding equals() you should generally override hashCode()
as well.
  Considering this is a private helper class not used in any hash tables or the
like I'm fine with not overriding hashCode if you don't want to bother with
that. But if you break the hashCode contract I think there should be a comment
about it above the class.

https://codereview.webrtc.org/1370063003/diff/100001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java:340: }
What about MeasureSpec.AT_MOST? What if X is restricted but not Y, will it be
stretched/squished?

https://codereview.webrtc.org/1370063003/diff/100001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java:354:
Math.max((float) layoutSize.x / frameWidth, (float) layoutSize.y / frameHeight);
Do we always want the max scale? Thinking about black borders vs scale-to-fill
etc.

https://codereview.webrtc.org/1370063003/diff/100001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java:361:
surfaceHeight = Math.round(layoutSize.y / displayScale);
How does the HW scaler know to take care of the upscaling?

https://codereview.webrtc.org/1370063003/diff/100001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java:471: private
boolean checkConsistentLayout() {
if (Thread.currentThread() != renderThread) throw exception