Issue 1370013002: Fix the C++ SurfaceTextureHolder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1370013002: Fix the C++ SurfaceTextureHolder (Closed)

Created:
5 years, 2 months ago by perkj_webrtc

Modified:
5 years, 2 months ago

Reviewers:
magjed_webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Fix the C++ SurfaceTextureHolder This cl moves back loading java SurfaceTextureHolder to the ClassReferenceHolder and use FindClass through ClassReferenceHolder. Without this, jni->FindClass returns nullptr in surfacetexturehelper_jni.cc. BUG=webrtc:4993 R=magjed@webrtc.org Committed: https://crrev.com/d2413e514ad9970f9a04e597275291ab95ad8a5c Cr-Commit-Position: refs/heads/master@{#10086}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	talk/app/webrtc/java/jni/classreferenceholder.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	talk/app/webrtc/java/jni/surfacetexturehelper_jni.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

perkj_webrtc

Committed patchset #1 (id:1) manually as d2413e514ad9970f9a04e597275291ab95ad8a5c (presubmit successful).

5 years, 2 months ago (2015-09-28 09:48:29 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-09-28 09:48:30 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d2413e514ad9970f9a04e597275291ab95ad8a5c
Cr-Commit-Position: refs/heads/master@{#10086}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages