webrtc/test/fake_encoder.cc - Issue 1369923005: Remove kSkipFrame usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/test/fake_encoder.cc

Issue 1369923005: Remove kSkipFrame usage. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: bogus default return value for ConvertFrameType Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/test/fake_encoder.cc

diff --git a/webrtc/test/fake_encoder.cc b/webrtc/test/fake_encoder.cc

index a840ddb68ac75c458d25f48495fb2b2a70143ffa..f85fb9abc1ab5821422989557f4d11f8ec4eb7d2 100644

--- a/webrtc/test/fake_encoder.cc

+++ b/webrtc/test/fake_encoder.cc

@@ -100,10 +100,8 @@ int32_t FakeEncoder::Encode(const VideoFrame& input_image,

encoded._encodedWidth = config_.simulcastStream[i].width;

encoded._encodedHeight = config_.simulcastStream[i].height;

// Always encode something on the first frame.

- if (min_stream_bits > bits_available && i > 0) {

- encoded._length = 0;

- encoded._frameType = kSkipFrame;

- }

+ if (min_stream_bits > bits_available && i > 0)

+ continue;

assert(callback_ != NULL);

if (callback_->Encoded(encoded, &specifics, NULL) != 0)

return -1;