webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc - Issue 1369923005: Remove kSkipFrame usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

Issue 1369923005: Remove kSkipFrame usage. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: bogus default return value for ConvertFrameType Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc ('k') | webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

index fdca8781bc62e80efc134142e7b9dd06607034a9..7dc75ed9e301d2c0e521b6e2ceb67145bf2f1b1b 100644

--- a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

@@ -351,6 +351,9 @@ TEST_F(TestSimulcastEncoderAdapterFake, SetChannelParameters) {

TEST_F(TestSimulcastEncoderAdapterFake, EncodedCallbackForDifferentEncoders) {

SetupCodec();

+ // Set bitrates so that we send all layers.

+ adapter_->SetRates(1200, 30);

// At this point, the simulcast encoder adapter should have 3 streams: HD,

// quarter HD, and quarter quarter HD. We're going to mostly ignore the exact

// resolutions, to test that the adapter forwards on the correct resolution