Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1369773003: Add a continual_gathering_policy in PeerConnection RTCConfiguration (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Addressed comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/peerconnectioninterface.h
diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h
index ca853385e6327fdcad52014b32abc115685e80c1..233b9a5897218539df6af4521ce725fa5b579aac 100644
--- a/talk/app/webrtc/peerconnectioninterface.h
+++ b/talk/app/webrtc/peerconnectioninterface.h
@@ -225,6 +225,11 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
kTcpCandidatePolicyDisabled
};
+ enum ContinuousGatheringPolicy {
pthatcher1 2015/09/25 22:26:57 Based on http://blog.dictionary.com/continually-vs
honghaiz3 2015/09/25 23:05:00 Done.
+ kGatheringOnce,
+ kGatheringContinuously
pthatcher1 2015/09/25 22:26:57 Cand kGatherContinually
pthatcher1 2015/09/25 22:26:57 The new enum style is GATHERING_CONTINUALLY.
pthatcher1 2015/09/25 22:26:57 kGatherOnce kGatherContinuosly
honghaiz3 2015/09/25 23:05:00 Done.
honghaiz3 2015/09/25 23:05:00 Done.
honghaiz3 2015/09/25 23:05:00 Done.
+ };
+
// TODO(hbos): Change into class with private data and public getters.
struct RTCConfiguration {
static const int kUndefined = -1;
@@ -245,6 +250,7 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
int audio_jitter_buffer_max_packets;
bool audio_jitter_buffer_fast_accelerate;
int ice_connection_receiving_timeout;
+ ContinuousGatheringPolicy continuous_gathering_policy;
std::vector<rtc::scoped_refptr<rtc::RTCCertificate>> certificates;
RTCConfiguration()
@@ -255,7 +261,8 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
tcp_candidate_policy(kTcpCandidatePolicyEnabled),
audio_jitter_buffer_max_packets(kAudioJitterBufferMaxPackets),
audio_jitter_buffer_fast_accelerate(false),
- ice_connection_receiving_timeout(kUndefined) {}
+ ice_connection_receiving_timeout(kUndefined),
+ continuous_gathering_policy(kGatheringOnce) {}
};
struct RTCOfferAnswerOptions {

Powered by Google App Engine
This is Rietveld 408576698