Add a continual_gathering_policy in PeerConnection RTCConfiguration

talk/app/webrtc/webrtcsession.cc

Index: talk/app/webrtc/webrtcsession.cc
diff --git a/talk/app/webrtc/webrtcsession.cc b/talk/app/webrtc/webrtcsession.cc
index bd1cd1a0ac8589af2b76977748e3ce7e6af25308..ce4227439f278eaae79dfa1f95dbf9d6ab6cc552 100644
--- a/talk/app/webrtc/webrtcsession.cc
+++ b/talk/app/webrtc/webrtcsession.cc
@@ -608,8 +608,7 @@ bool WebRtcSession::Initialize(
     certificate = rtc_configuration.certificates[0];
   }
 
-  SetIceConnectionReceivingTimeout(
-      rtc_configuration.ice_connection_receiving_timeout);
+  SetIceConfig(ParseIceConfig(rtc_configuration));
 
   // TODO(perkj): Take |constraints| into consideration. Return false if not all
   // mandatory constraints can be fulfilled. Note that |constraints|
@@ -782,6 +781,14 @@ bool WebRtcSession::Initialize(
   return true;
 }
 
+cricket::IceConfig WebRtcSession::ParseIceConfig(
+    const PeerConnectionInterface::RTCConfiguration& config) const {
+  cricket::IceConfig ice_config;
+  ice_config.receiving_timeout_ms = config.ice_connection_receiving_timeout;
+  ice_config.continue_getting_ports = config.ice_continue_getting_ports;

[pthatcher1, 2015/09/25 17:37:47]

Instead of copying all the settings, can we just embed a whole IceConfig into
the RTCConfiguration?

[honghaiz3, 2015/09/25 20:10:20]

It is probably better to separate the PeerConnection interface from the internal
implementation. This is also typical for most other policies. 

+  return ice_config;
+}
+
 void WebRtcSession::Terminate() {
   SetState(STATE_RECEIVEDTERMINATE);
   RemoveUnusedChannels(NULL);