Add a continual_gathering_policy in PeerConnection RTCConfiguration

webrtc/p2p/base/p2ptransportchannel.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 56 matching lines @@
                          const std::string& ice_pwd) override;
   void SetRemoteIceCredentials(const std::string& ice_ufrag,
                                const std::string& ice_pwd) override;
   void SetRemoteIceMode(IceMode mode) override;
   void Connect() override;
   void MaybeStartGathering() override;
   IceGatheringState gathering_state() const override {
     return gathering_state_;
   }
   void AddRemoteCandidate(const Candidate& candidate) override;
-  // Sets the receiving timeout in milliseconds.
+  // Sets the receiving timeout and continue_getting_ports.
   // This also sets the check_receiving_delay proportionally.
-  void SetReceivingTimeout(int receiving_timeout_ms) override;
+  void SetIceConfig(const IceConfig& config) override;
 
   // From TransportChannel:
   int SendPacket(const char* data,
                  size_t len,
                  const rtc::PacketOptions& options,
                  int flags) override;
   int SetOption(rtc::Socket::Option opt, int value) override;
   bool GetOption(rtc::Socket::Option opt, int* value) override;
   int GetError() override { return error_; }
   bool GetStats(std::vector<ConnectionInfo>* stats) override;
@@ skipping 153 matching lines @@
   std::string remote_ice_pwd_;
   IceMode remote_ice_mode_;
   IceRole ice_role_;
   uint64 tiebreaker_;
   uint32 remote_candidate_generation_;
   IceGatheringState gathering_state_;
 
   int check_receiving_delay_;
   int receiving_timeout_;
   uint32 last_ping_sent_ms_ = 0;
+  bool continue_getting_ports_ = false;

[pthatcher1, 2015/09/25 17:37:47]

Why not store the config instead of storing both receiving_timeout_ and
continue_getting_ports_?

[honghaiz3, 2015/09/25 20:10:20]

The config is used to pass the infomation down. 
But this two values are used completely separate here. 
It is more convenient to have two variables when using them.
Plus, when setting we need to check the value of timeout but not the other var.
If we just blindly save the whole ice_config, then we need to check the
receiving time everytime when using it. 
Renamed it 

 
   RTC_DISALLOW_COPY_AND_ASSIGN(P2PTransportChannel);
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_P2P_BASE_P2PTRANSPORTCHANNEL_H_