Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1369683004: Analyze support in gyp_webrtc (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Analyze support in gyp_webrtc BUG=chromium:482463 TESTED=Manually tested using the JSON files attached to https://code.google.com/p/chromium/issues/detail?id=482463#c2 and: webrtc/build/gyp_webrtc --analyzer nothing-files.json nothing-files-RESULT.json webrtc/build/gyp_webrtc --analyzer everything-files.json everything-files-RESULT.json webrtc/build/gyp_webrtc --analyzer test_support_unittests-files.json test_support_unittests-files-RESULT.json Then I verified the result-json contained the expected output. R=phoglund@webrtc.org Committed: https://crrev.com/8108764552e20d657c0a6f75a6200b93de486659 Cr-Commit-Position: refs/heads/master@{#10097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M webrtc/build/gyp_webrtc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kjellander_webrtc
The argument parsing implementation is kind of ugly but it's a pristine copy of https://code.google.com/p/chromium/codesearch#chromium/src/build/gyp_chromium.py&l=204 ...
5 years, 2 months ago (2015-09-25 18:44:27 UTC) #2
phoglund
Myeh, I think it's alright. It's likely to fail ugly if there are too few ...
5 years, 2 months ago (2015-09-28 06:42:16 UTC) #3
kjellander_webrtc
Committed patchset #1 (id:1) manually as 8108764552e20d657c0a6f75a6200b93de486659 (presubmit successful).
5 years, 2 months ago (2015-09-28 19:56:58 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8108764552e20d657c0a6f75a6200b93de486659 Cr-Commit-Position: refs/heads/master@{#10097}
5 years, 2 months ago (2015-09-28 19:57:01 UTC) #5
kjellander_webrtc
4 years, 10 months ago (2016-02-09 06:44:42 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1681023003/ by kjellander@webrtc.org.

The reason for reverting is: I've decided to not aim for implementing analyze
and focus on getting Swarming done instead, so I'm cleaning this up..

Powered by Google App Engine
This is Rietveld 408576698