Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1369333010: autoroller: Add TBR= field and always update the checkout (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

autoroller: Add TBR= field and always update the checkout Add a TBR= field to enable automated rolling. In some cases, add a committer to the field, for other rolls: leave it empty. Always run 'git pull', even if --dry-run is specified, as it is often used to just generate an updated commit message to update an existing CL with when updating it to match fixes in Chromium. BUG=webrtc:4688 R=phoglund@webrtc.org Committed: https://crrev.com/6c2ba7d13c1a0f733fa993f3e5145ea795d356ce Cr-Commit-Position: refs/heads/master@{#10140}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M tools/autoroller/roll_chromium_revision.py View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
Having TBR= is needed if we're going to automate this. I hacked in some authors ...
5 years, 2 months ago (2015-10-01 15:57:38 UTC) #3
phoglund
lgtm
5 years, 2 months ago (2015-10-02 06:50:02 UTC) #4
kjellander_webrtc
Committed patchset #1 (id:20001) manually as 6c2ba7d13c1a0f733fa993f3e5145ea795d356ce (presubmit successful).
5 years, 2 months ago (2015-10-02 07:03:32 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 07:03:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c2ba7d13c1a0f733fa993f3e5145ea795d356ce
Cr-Commit-Position: refs/heads/master@{#10140}

Powered by Google App Engine
This is Rietveld 408576698