Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1368933002: Revert of Don't link with audio codecs that we don't use (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@dmove-clean
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Don't link with audio codecs that we don't use (patchset #4 id:60001 of https://codereview.webrtc.org/1349393003/ ) Reason for revert: Breaking Chromium FYI bots. Original issue's description: > Don't link with audio codecs that we don't use > > We used to link with all audio codecs unconditionally (except Opus); > this patch makes gyp and gn only link to the ones that are used. > > (This unfortunately fails to have a measurable impact on Chromium > binary size, at least on x86_64 Linux; it turns out that iLBC and iSAC > fix were already being excluded from Chromium by some other means > (likely just the linker omitting compilation units with no incoming > references).) > > BUG=webrtc:4557 > > Committed: https://crrev.com/f66a9251424351ea6d631c54dd1feb64cc13d809 > Cr-Commit-Position: refs/heads/master@{#10046} TBR=henrik.lundin@webrtc.org,tina.legrand@webrtc.org,kjellander@webrtc.org,kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4557 Committed: https://crrev.com/3fd7be4cb1d41ff6298a90c17acf52d379ab8812 Cr-Commit-Position: refs/heads/master@{#10069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -100 lines) Patch
M webrtc/build/common.gypi View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/engine_configurations.h View 1 chunk +21 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 4 chunks +10 lines, -37 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner.cc View 1 chunk +9 lines, -12 lines 0 comments Download
M webrtc/modules/audio_coding/main/audio_coding_module.gypi View 2 chunks +5 lines, -17 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 4 chunks +9 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
the sun
Created Revert of Don't link with audio codecs that we don't use
5 years, 3 months ago (2015-09-25 08:35:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368933002/1
5 years, 3 months ago (2015-09-25 08:35:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-25 08:36:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3fd7be4cb1d41ff6298a90c17acf52d379ab8812 Cr-Commit-Position: refs/heads/master@{#10069}
5 years, 3 months ago (2015-09-25 08:36:18 UTC) #4
kwiberg-webrtc
5 years, 2 months ago (2015-09-25 09:31:24 UTC) #5
Message was sent while issue was closed.
On 2015/09/25 08:36:18, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/3fd7be4cb1d41ff6298a90c17acf52d379ab8812
> Cr-Commit-Position: refs/heads/master@{#10069}

lgtm

Powered by Google App Engine
This is Rietveld 408576698