Don't link with audio codecs that we don't use

Don't link with audio codecs that we don't use

We used to link with all audio codecs unconditionally (except Opus);
this patch makes gyp and gn only link to the ones that are used.

This unfortunately fails to have a measurable impact on Chromium
binary size, at least on x86_64 Linux; it turns out that iLBC and iSAC
fix were already being excluded from Chromium by some other means,
likely just the linker omitting compilation units with no incoming
references.

(This was previously landed as revisions 10046 and 10060, and got
reverted because it broke several of the Chromium FYI bots.)

BUG=webrtc:4557
Committed: https://crrev.com/98ab3a46d6b98bd6626ab741092f7cbf104d127b
Cr-Commit-Position: refs/heads/master@{#10127}

[kwiberg-webrtc, 2015-09-25 20:51:53]

Patchset #3 (id:40001) has been deleted

[kwiberg-webrtc, 2015-09-30 04:21:04]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2015-09-30 04:21:15]

Patchset #1 (id:20001) has been deleted

[kwiberg-webrtc, 2015-09-30 04:21:27]

Patchset #1 (id:60001) has been deleted

[kwiberg-webrtc, 2015-09-30 04:21:40]

Patchset #1 (id:80001) has been deleted

[kwiberg-webrtc, 2015-09-30 04:21:55]

Patchset #1 (id:100001) has been deleted

[kwiberg-webrtc, 2015-09-30 11:39:23]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, tina.legrand@webrtc.org

[kwiberg-webrtc, 2015-09-30 11:44:50]

Tina: engine_configurations.h
Henrik: Everything

Patch set #1 is the original two CLs. Patch set #2 is the fixes on top of that.

In https://codereview.webrtc.org/1367013004/ and
https://codereview.webrtc.org/1366303002/, I've asked the trybots to compile
this CL with the Chromium and FF codec sets, to make sure that works.

[hlundin-webrtc, 2015-09-30 12:53:27]

lgtm with two comments.

https://codereview.webrtc.org/1368843003/diff/140001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/main/acm2/acm_receive_test.cc (right):

https://codereview.webrtc.org/1368843003/diff/140001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/main/acm2/acm_receive_test.cc:78: void
AcmReceiveTest::RegisterNetEqTestCodecs() {
Won't this method need the same treatment as above?

https://codereview.webrtc.org/1368843003/diff/140001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/main/test/TestRedFec.cc (right):

https://codereview.webrtc.org/1368843003/diff/140001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/main/test/TestRedFec.cc:40: #ifdef WEBRTC_CODEC_G722
Please, comment on what is going on here. Courtesy to future you.

[kwiberg-webrtc, 2015-09-30 13:25:41]

https://codereview.webrtc.org/1368843003/diff/140001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/main/acm2/acm_receive_test.cc (right):

https://codereview.webrtc.org/1368843003/diff/140001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/main/acm2/acm_receive_test.cc:78: void
AcmReceiveTest::RegisterNetEqTestCodecs() {
On 2015/09/30 12:53:26, hlundin-webrtc wrote:
> Won't this method need the same treatment as above?

It would, if it was called from a test that wasn't already disabled if we
compile without the full set of codecs.

https://codereview.webrtc.org/1368843003/diff/140001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/main/test/TestRedFec.cc (right):

https://codereview.webrtc.org/1368843003/diff/140001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/main/test/TestRedFec.cc:40: #ifdef WEBRTC_CODEC_G722
On 2015/09/30 12:53:27, hlundin-webrtc wrote:
> Please, comment on what is going on here. Courtesy to future you.

Done.

[tlegrand-webrtc, 2015-09-30 13:58:18]

lgtm

[kwiberg-webrtc, 2015-10-01 04:10:39]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2015-10-01 04:10:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1368843003/#ps160001 (title:
"Add comment")

[commit-bot: I haz the power, 2015-10-01 04:10:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1368843003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1368843003/160001

[commit-bot: I haz the power, 2015-10-01 04:54:26]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2015-10-01 04:54:35]

Patchset 3 (id:??) landed as
https://crrev.com/98ab3a46d6b98bd6626ab741092f7cbf104d127b
Cr-Commit-Position: refs/heads/master@{#10127}