Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1368083002: Revert of CodecOwner: Don't look at definitions for classes we don't link with (Closed)

Created:
5 years, 2 months ago by the sun
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, tlegrand-webrtc, the sun, tommi
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of CodecOwner: Don't look at definitions for classes we don't link with (patchset #1 id:1 of https://codereview.webrtc.org/1364233002/ ) Reason for revert: Breaking Chromium FYI bots. Original issue's description: > CodecOwner: Don't look at definitions for classes we don't link with > > It's good hygiene and just generally the right thing to do. And > apparently at least sometimes required by Microsoft's compiler. > > Committed: https://crrev.com/f4d38ea57aa739b525066b095468cb4af1d2799b > Cr-Commit-Position: refs/heads/master@{#10060} TBR=henrik.lundin@webrtc.org,tommi@webrtc.org,kwiberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a53e383d7dfb1e655e2b0e082eb26ea0407fb285 Cr-Commit-Position: refs/heads/master@{#10068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M webrtc/modules/audio_coding/main/acm2/codec_owner.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
the sun
Created Revert of CodecOwner: Don't look at definitions for classes we don't link with
5 years, 2 months ago (2015-09-25 08:30:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368083002/1
5 years, 2 months ago (2015-09-25 08:30:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 08:31:01 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a53e383d7dfb1e655e2b0e082eb26ea0407fb285 Cr-Commit-Position: refs/heads/master@{#10068}
5 years, 2 months ago (2015-09-25 08:31:11 UTC) #4
kwiberg-webrtc
5 years, 2 months ago (2015-09-25 09:32:59 UTC) #5
Message was sent while issue was closed.
On 2015/09/25 08:31:11, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/a53e383d7dfb1e655e2b0e082eb26ea0407fb285
> Cr-Commit-Position: refs/heads/master@{#10068}

lgtm

Powered by Google App Engine
This is Rietveld 408576698