Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1368053002: Fallback to system log when webrtc tracing not enabled. (Closed)

Created:
5 years, 3 months ago by jiayl2
Modified:
5 years, 2 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fallback to system log when webrtc tracing not enabled. BUG= R=glaznev@webrtc.org Committed: https://crrev.com/4d47aa335c6d3cd99df4627ae3445ac08cea0a29 Cr-Commit-Position: refs/heads/master@{#10079}

Patch Set 1 #

Total comments: 2

Patch Set 2 : synchronize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M webrtc/base/java/src/org/webrtc/Logging.java View 1 2 chunks +30 lines, -19 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
jiayl2
PTAL
5 years, 3 months ago (2015-09-24 22:52:05 UTC) #2
AlexG
lgtm https://codereview.webrtc.org/1368053002/diff/1/webrtc/base/java/src/org/webrtc/Logging.java File webrtc/base/java/src/org/webrtc/Logging.java (right): https://codereview.webrtc.org/1368053002/diff/1/webrtc/base/java/src/org/webrtc/Logging.java#newcode22 webrtc/base/java/src/org/webrtc/Logging.java:22: private static boolean tracingEnabled; synchronized?
5 years, 3 months ago (2015-09-24 23:41:38 UTC) #3
jiayl2
https://codereview.webrtc.org/1368053002/diff/1/webrtc/base/java/src/org/webrtc/Logging.java File webrtc/base/java/src/org/webrtc/Logging.java (right): https://codereview.webrtc.org/1368053002/diff/1/webrtc/base/java/src/org/webrtc/Logging.java#newcode22 webrtc/base/java/src/org/webrtc/Logging.java:22: private static boolean tracingEnabled; On 2015/09/24 23:41:37, AlexG wrote: ...
5 years, 3 months ago (2015-09-24 23:47:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368053002/20001
5 years, 3 months ago (2015-09-24 23:48:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/4923)
5 years, 3 months ago (2015-09-25 00:11:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368053002/20001
5 years, 3 months ago (2015-09-25 00:21:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
5 years, 3 months ago (2015-09-25 01:48:10 UTC) #13
jiayl2
Committed patchset #2 (id:20001) manually as 4d47aa335c6d3cd99df4627ae3445ac08cea0a29 (presubmit successful).
5 years, 2 months ago (2015-09-25 17:04:41 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 17:04:44 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4d47aa335c6d3cd99df4627ae3445ac08cea0a29
Cr-Commit-Position: refs/heads/master@{#10079}

Powered by Google App Engine
This is Rietveld 408576698