Android GlRectDrawer: Add test for OES texture rendering

Android GlRectDrawer: Add test for OES texture rendering

BUG=webrtc:4742
R=hbos@webrtc.org

Committed: https://crrev.com/24b52f8322ae225f5e95b9f4d33c976add803a81
Cr-Commit-Position: refs/heads/master@{#10109}

[magjed_webrtc, 2015-09-24 13:14:53]

magjed@webrtc.org changed reviewers:
+ hbos@webrtc.org

[magjed_webrtc, 2015-09-24 13:22:25]

hbos - Please take a look. This CL adds a helper class StubOesTextureProducer
for generating test OES textures that has a dependency on the class
SurfaceTextureHelper. I plan to rename the class GlRectDrawerTest into something
more generic and also add SurfaceTextureHelper specific tests into that class.
The reason for this merge is that the tests for GlRectDrawer and
SurfaceTextureHelper are very overlapping.

[magjed_webrtc, 2015-09-24 16:16:45]

You can wait with reviewing this CL because both RGB and OES render tests fails
on Nexus 9.

[magjed_webrtc, 2015-09-28 21:21:00]

Patchset #3 (id:40001) has been deleted

[magjed_webrtc, 2015-09-28 21:21:06]

Patchset #2 (id:20001) has been deleted

[magjed_webrtc, 2015-09-28 21:21:15]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2015-09-29 08:00:47]

Patchset #2 (id:80001) has been deleted

[magjed_webrtc, 2015-09-29 08:00:52]

Patchset #1 (id:60001) has been deleted

[magjed_webrtc, 2015-09-29 08:03:51]

It should be working now. hbos@ - Please take a look.

[hbos, 2015-09-29 08:24:31]

https://codereview.webrtc.org/1367913003/diff/100001/talk/app/webrtc/androidt...
File talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java (right):

https://codereview.webrtc.org/1367913003/diff/100001/talk/app/webrtc/androidt...
talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java:42: public
final class GlRectDrawerTest extends ActivityTestCase {
Did you figure out what to do with test classes in terms of access modifier?
public the way to go?

https://codereview.webrtc.org/1367913003/diff/100001/talk/app/webrtc/androidt...
talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java:214: public
void testOesRendering() throws InterruptedException {
Add a comment/comments somewhere explaining that a lot of the test is just a way
to create the OES texture. A short text summary what the test is doing.
Otherwise it looks confusing that so much is going on in the test when what
we're supposed to be testing is GlRectDrawer.drawOes.

[magjed_webrtc, 2015-09-29 09:50:19]

https://codereview.webrtc.org/1367913003/diff/100001/talk/app/webrtc/androidt...
File talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java (right):

https://codereview.webrtc.org/1367913003/diff/100001/talk/app/webrtc/androidt...
talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java:42: public
final class GlRectDrawerTest extends ActivityTestCase {
On 2015/09/29 08:24:31, hbos wrote:
> Did you figure out what to do with test classes in terms of access modifier?
> public the way to go?

Yes, it doesn't work with package private.

https://codereview.webrtc.org/1367913003/diff/100001/talk/app/webrtc/androidt...
talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java:214: public
void testOesRendering() throws InterruptedException {
On 2015/09/29 08:24:31, hbos wrote:
> Add a comment/comments somewhere explaining that a lot of the test is just a
way
> to create the OES texture. A short text summary what the test is doing.
> Otherwise it looks confusing that so much is going on in the test when what
> we're supposed to be testing is GlRectDrawer.drawOes.

Done.

[hbos, 2015-09-29 14:18:31]

lgtm if trybots are happy

https://codereview.webrtc.org/1367913003/diff/120001/talk/app/webrtc/androidt...
File talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java (right):

https://codereview.webrtc.org/1367913003/diff/120001/talk/app/webrtc/androidt...
talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java:218: *  -
Create an EglBase with the SurfaceTexture as EglSurface.
s/EglSurface/EGLSurface

https://codereview.webrtc.org/1367913003/diff/120001/talk/app/webrtc/androidt...
talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java:296: // Real
test start here.
Keepin it realz

[magjed_webrtc, 2015-09-29 14:40:17]

Committed patchset #3 (id:140001) manually as
24b52f8322ae225f5e95b9f4d33c976add803a81 (presubmit successful).

[commit-bot: I haz the power, 2015-09-29 14:40:20]

Patchset 3 (id:??) landed as
https://crrev.com/24b52f8322ae225f5e95b9f4d33c976add803a81
Cr-Commit-Position: refs/heads/master@{#10109}