Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1367523009: Remove custom handler since the logger already logs to console by default. (Closed)

Created:
5 years, 3 months ago by jiayl2
Modified:
5 years, 3 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove custom handler since the logger already logs to console by default. BUG= R=glaznev@webrtc.org Committed: https://crrev.com/4ba059d2183c621e05a34a7b0a907d606348246f Cr-Commit-Position: refs/heads/master@{#10064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M webrtc/base/java/src/org/webrtc/Logging.java View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
jiayl2
PTAL
5 years, 3 months ago (2015-09-24 16:13:40 UTC) #2
AlexG
lgtm
5 years, 3 months ago (2015-09-24 16:50:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367523009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367523009/1
5 years, 3 months ago (2015-09-24 17:18:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
5 years, 3 months ago (2015-09-24 18:14:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367523009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367523009/1
5 years, 3 months ago (2015-09-24 18:15:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/7881)
5 years, 3 months ago (2015-09-24 20:15:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367523009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367523009/1
5 years, 3 months ago (2015-09-24 20:16:32 UTC) #13
jiayl2
Committed patchset #1 (id:1) manually as 4ba059d2183c621e05a34a7b0a907d606348246f (presubmit successful).
5 years, 3 months ago (2015-09-24 21:36:23 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 21:36:28 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4ba059d2183c621e05a34a7b0a907d606348246f
Cr-Commit-Position: refs/heads/master@{#10064}

Powered by Google App Engine
This is Rietveld 408576698