Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc

Issue 1367193002: Fix bug where rtcp::TransportFeedback may generate incorrect messages. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed associated bug in rtcp_receiver plus added tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
index fba45478629cdbba70942014464828293d5a137d..4ad49561b80cc61abbba5265f1e6fbcc0df5a384 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
@@ -447,7 +447,7 @@ bool TransportFeedback::Encode(StatusSymbol symbol) {
return true;
} else {
// New symbol does not match what's already in symbol_vec.
- if (first_symbol_cardinality_ > capacity) {
+ if (first_symbol_cardinality_ >= capacity) {
// Symbols in symbol_vec can only be RLE-encoded. Emit the RLE-chunk
// and re-add input. symbol_vec is then guaranteed to have room for the
// symbol, so recursion cannot continue.

Powered by Google App Engine
This is Rietveld 408576698