Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1366583002: Add stats for rendered pixels (sqrt(w*h)) per second: (Closed)

Created:
5 years, 3 months ago by åsapersson
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add stats for rendered pixels (sqrt(w*h)) per second: - "WebRTC.Video.RenderSqrtPixelsPerSecond" BUG=chromium:512752 Committed: https://crrev.com/f839dcc8709243d1d81d5a23eb15aa43fc0466f6 Cr-Commit-Position: refs/heads/master@{#10208}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : address comment #

Patch Set 4 : add min required samples #

Patch Set 5 : #

Patch Set 6 : renamed histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M webrtc/video/receive_statistics_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 2 3 4 5 5 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
åsapersson
5 years, 3 months ago (2015-09-23 13:00:55 UTC) #2
pbos-webrtc
lgtm https://codereview.webrtc.org/1366583002/diff/20001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/1366583002/diff/20001/webrtc/video/receive_statistics_proxy.cc#newcode156 webrtc/video/receive_statistics_proxy.cc:156: if (width > 0 && height > 0) ...
5 years, 3 months ago (2015-09-23 13:39:20 UTC) #3
åsapersson
https://codereview.webrtc.org/1366583002/diff/20001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/1366583002/diff/20001/webrtc/video/receive_statistics_proxy.cc#newcode156 webrtc/video/receive_statistics_proxy.cc:156: if (width > 0 && height > 0) On ...
5 years, 3 months ago (2015-09-23 14:07:54 UTC) #4
stefan-webrtc
Please correct the description of this CL as you are not adding a histogram for ...
5 years, 2 months ago (2015-09-25 13:02:48 UTC) #5
stefan-webrtc
lgtm
5 years, 2 months ago (2015-09-25 13:02:54 UTC) #6
åsapersson
On 2015/09/25 13:02:48, stefan-webrtc (holmer) wrote: > Please correct the description of this CL as ...
5 years, 2 months ago (2015-09-25 13:50:15 UTC) #7
mflodman
On 2015/09/25 13:50:15, åsapersson wrote: > On 2015/09/25 13:02:48, stefan-webrtc (holmer) wrote: > > Please ...
5 years, 2 months ago (2015-09-30 11:28:05 UTC) #8
åsapersson
On 2015/09/30 11:28:05, mflodman wrote: > On 2015/09/25 13:50:15, åsapersson wrote: > > On 2015/09/25 ...
5 years, 2 months ago (2015-10-05 14:07:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366583002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366583002/100001
5 years, 2 months ago (2015-10-08 06:53:48 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 2 months ago (2015-10-08 07:42:04 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 07:42:18 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f839dcc8709243d1d81d5a23eb15aa43fc0466f6
Cr-Commit-Position: refs/heads/master@{#10208}

Powered by Google App Engine
This is Rietveld 408576698