Issue 1365063004: GN: Do not use forward_dependent_configs_from variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1365063004: GN: Do not use forward_dependent_configs_from variable. (Closed)

Created:
5 years, 3 months ago by tfarina

Modified:
5 years, 2 months ago

Reviewers:
brettw, kjellander_webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

GN: Do not use forward_dependent_configs_from variable. It is deprecated and public_deps should be used instead, which will have the same effect. BUG=None R=brettw@chromium.org,kjellander@webrtc.org Committed: https://crrev.com/702f39726bf06e29b2cfca564261c48a1c08cbc0 Cr-Commit-Position: refs/heads/master@{#10074}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	webrtc/modules/audio_coding/BUILD.gn	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365063004/1

5 years, 2 months ago (2015-09-25 12:50:07 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-09-25 12:58:01 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/702f39726bf06e29b2cfca564261c48a1c08cbc0
Cr-Commit-Position: refs/heads/master@{#10074}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages