Wire up QualityScaler for H.264 on Android.

Wire up QualityScaler for H.264 on Android.

BUG=webrtc:4968
R=magjed@webrtc.org, stefan@webrtc.org

Committed: https://crrev.com/2bc68c731dd1e643f89d636de4cdb1dc5d63bd40
Cr-Commit-Position: refs/heads/master@{#10055}

[pbos-webrtc, 2015-09-24 13:09:14]

PTAL, I have a pending CL that also adds high-QP thresholds to QualityScaler.

[stefan-webrtc, 2015-09-24 13:32:24]

https://codereview.webrtc.org/1365063002/diff/1/talk/app/webrtc/java/jni/andr...
File talk/app/webrtc/java/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/1365063002/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:36: #include
"webrtc/modules/rtp_rtcp/source/h264_bitstream_parser.h"
I think we should move this somewhere else, it doesn't make sense to have it in
rtp_rtcp. But I don't know where it fits, so let's keep it here...

https://codereview.webrtc.org/1365063002/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:788: if (payload_size &&
scale_)
Remove payload_size &&

Can't imagine that it is necessary?

[pbos-webrtc, 2015-09-24 14:10:27]

feedback

[pbos-webrtc, 2015-09-24 14:10:52]

PTAL

https://codereview.webrtc.org/1365063002/diff/1/talk/app/webrtc/java/jni/andr...
File talk/app/webrtc/java/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/1365063002/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:36: #include
"webrtc/modules/rtp_rtcp/source/h264_bitstream_parser.h"
On 2015/09/24 13:32:24, stefan-webrtc (holmer) wrote:
> I think we should move this somewhere else, it doesn't make sense to have it
in
> rtp_rtcp. But I don't know where it fits, so let's keep it here...

Acknowledged.

https://codereview.webrtc.org/1365063002/diff/1/talk/app/webrtc/java/jni/andr...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:788: if (payload_size &&
scale_)
On 2015/09/24 13:32:24, stefan-webrtc (holmer) wrote:
> Remove payload_size &&
> 
> Can't imagine that it is necessary?

Done.

[pbos-webrtc, 2015-09-24 14:12:14]

pbos@webrtc.org changed reviewers:
+ magjed@webrtc.org
- glaznev@webrtc.org

[pbos-webrtc, 2015-09-24 14:12:41]

-> magjed@ for owners who is closest in this directory structure thing

[stefan-webrtc, 2015-09-24 14:13:20]

lgtm

[magjed_webrtc, 2015-09-24 14:20:36]

lgtm

[commit-bot: I haz the power, 2015-09-24 14:22:45]

Patchset 2 (id:??) landed as
https://crrev.com/2bc68c731dd1e643f89d636de4cdb1dc5d63bd40
Cr-Commit-Position: refs/heads/master@{#10055}

[pbos-webrtc, 2015-09-24 14:22:45]

Committed patchset #2 (id:20001) manually as
2bc68c731dd1e643f89d636de4cdb1dc5d63bd40 (presubmit successful).