Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1364813004: Adding stub files for RtpSender/RtpReceiver. (Closed)

Created:
5 years, 3 months ago by Taylor Brandstetter
Modified:
5 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding stub files for RtpSender/RtpReceiver. This will allow Chromium's build files to be updated, so that when the real RtpSender CL is submitted, it doesn't break the FYI bots. Committed: https://crrev.com/6979b024d7cebfdcd1e8f66da59ea157bbc9e47e Cr-Commit-Position: refs/heads/master@{#10065}

Patch Set 1 #

Patch Set 2 : Expanding stubs so they pass presubmit checks... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
A + talk/app/webrtc/rtpreceiver.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
A + talk/app/webrtc/rtpreceiver.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
A + talk/app/webrtc/rtpreceiverinterface.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
A + talk/app/webrtc/rtpsender.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
A + talk/app/webrtc/rtpsender.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
A + talk/app/webrtc/rtpsenderinterface.h View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Taylor Brandstetter
5 years, 3 months ago (2015-09-23 17:57:23 UTC) #2
pthatcher1
lgtm
5 years, 3 months ago (2015-09-23 18:12:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364813004/1
5 years, 3 months ago (2015-09-23 18:20:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/906)
5 years, 3 months ago (2015-09-23 18:22:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364813004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364813004/20001
5 years, 2 months ago (2015-09-24 23:46:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-24 23:47:58 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-24 23:48:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6979b024d7cebfdcd1e8f66da59ea157bbc9e47e
Cr-Commit-Position: refs/heads/master@{#10065}

Powered by Google App Engine
This is Rietveld 408576698