Do not prune if the current best connection is weak.

Do not prune if the current best connection is weak.
Otherwise, we may delete a useful connection because the current best connection may be failing.

BUG=

Committed: https://crrev.com/8937437872d8ff5b30866ae4de4abf005afc7539
Cr-Commit-Position: refs/heads/master@{#10063}

[honghaiz3, 2015-09-23 16:53:49]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2015-09-23 17:06:59]

Patchset #1 (id:20001) has been deleted

[honghaiz3, 2015-09-23 17:12:03]

Patchset #1 (id:40001) has been deleted

[honghaiz3, 2015-09-23 17:17:33]

honghaiz@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[honghaiz3, 2015-09-23 17:17:34]

This CL is important for continuous nomination lite to work. 
It only makes things safer by having less chance of pruning.

[pthatcher1, 2015-09-23 19:56:09]

Can you write a unit test for it?

[honghaiz3, 2015-09-24 00:47:09]

On 2015/09/23 19:56:09, pthatcher1 wrote:
> Can you write a unit test for it?

Done.

[honghaiz3, 2015-09-24 00:54:09]

Patchset #2 (id:80001) has been deleted

[honghaiz3, 2015-09-24 01:08:26]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-24 01:08:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364683002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364683002/100001

[commit-bot: I haz the power, 2015-09-24 01:08:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 01:08:45]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[honghaiz3, 2015-09-24 01:10:23]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-24 01:10:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364683002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364683002/100001

[commit-bot: I haz the power, 2015-09-24 01:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 01:10:54]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[honghaiz3, 2015-09-24 04:20:12]

Patchset #3 (id:120001) has been deleted

[honghaiz3, 2015-09-24 04:20:18]

Patchset #2 (id:100001) has been deleted

[pthatcher1, 2015-09-24 06:35:22]

lgtm

https://codereview.webrtc.org/1364683002/diff/140001/webrtc/p2p/base/p2ptrans...
File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right):

https://codereview.webrtc.org/1364683002/diff/140001/webrtc/p2p/base/p2ptrans...
webrtc/p2p/base/p2ptransportchannel_unittest.cc:1937:
TEST_F(P2PTransportChannelPingTest, TestPruneConnections) {
Would a better name be TestDontPruneWhenWeak?

[honghaiz3, 2015-09-24 16:48:49]

https://codereview.webrtc.org/1364683002/diff/140001/webrtc/p2p/base/p2ptrans...
File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right):

https://codereview.webrtc.org/1364683002/diff/140001/webrtc/p2p/base/p2ptrans...
webrtc/p2p/base/p2ptransportchannel_unittest.cc:1937:
TEST_F(P2PTransportChannelPingTest, TestPruneConnections) {
On 2015/09/24 06:35:21, pthatcher1 wrote:
> Would a better name be TestDontPruneWhenWeak?

Done.

[honghaiz3, 2015-09-24 16:50:21]

Patchset #3 (id:160001) has been deleted

[honghaiz3, 2015-09-24 16:51:19]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2015-09-24 16:51:19]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1364683002/#ps180001 (title:
"Change the test name and merge")

[commit-bot: I haz the power, 2015-09-24 16:51:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364683002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364683002/180001

[commit-bot: I haz the power, 2015-09-24 18:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 18:51:50]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[honghaiz3, 2015-09-24 19:29:44]

The CQ bit was checked by honghaiz@webrtc.org

[commit-bot: I haz the power, 2015-09-24 19:29:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364683002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364683002/180001

[commit-bot: I haz the power, 2015-09-24 20:14:53]

Committed patchset #3 (id:180001)

[commit-bot: I haz the power, 2015-09-24 20:14:55]

Patchset 3 (id:??) landed as
https://crrev.com/8937437872d8ff5b30866ae4de4abf005afc7539
Cr-Commit-Position: refs/heads/master@{#10063}