webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc - Issue 1364253002: Implement a high-QP threshold for Android H.264.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

Issue 1364253002: Implement a high-QP threshold for Android H.264. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « talk/app/webrtc/java/jni/androidmediaencoder_jni.cc ('k') | webrtc/modules/video_coding/utility/include/quality_scaler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

index 48ed02ae351443313369e2c4d038e38131a9386b..651406abf91d0c01f5eebaf7adb5bbe7d013e2ea 100644

--- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

@@ -579,8 +579,11 @@ int VP8EncoderImpl::InitEncode(const VideoCodec* inst,

}

rps_.Init();

+ // Disable both high-QP limits and framedropping. Both are handled by libvpx

+ // internally.

+ const int kDisabledBadQpThreshold = 64;

quality_scaler_.Init(codec_.qpMax / QualityScaler::kDefaultLowQpDenominator,

- false);

+ kDisabledBadQpThreshold, false);

quality_scaler_.ReportFramerate(codec_.maxFramerate);

return InitAndSetControlSettings();