Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1364233002: CodecOwner: Don't look at definitions for classes we don't link with (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 2 months ago
Reviewers:
tommi, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, tlegrand-webrtc, the sun, tommi
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

CodecOwner: Don't look at definitions for classes we don't link with It's good hygiene and just generally the right thing to do. And apparently at least sometimes required by Microsoft's compiler. Committed: https://crrev.com/f4d38ea57aa739b525066b095468cb4af1d2799b Cr-Commit-Position: refs/heads/master@{#10060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M webrtc/modules/audio_coding/main/acm2/codec_owner.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
kwiberg-webrtc
Henrik: please review. This was left out of my recent linking CL by mistake. Sheriff ...
5 years, 3 months ago (2015-09-24 14:01:25 UTC) #2
kwiberg-webrtc
On 2015/09/24 14:01:25, kwiberg-webrtc wrote: > Henrik: please review. This was left out of my ...
5 years, 3 months ago (2015-09-24 14:04:49 UTC) #3
tommi
lgtm
5 years, 3 months ago (2015-09-24 14:13:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364233002/1
5 years, 3 months ago (2015-09-24 14:13:37 UTC) #7
hlundin-webrtc
lgtm
5 years, 2 months ago (2015-09-24 15:46:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
5 years, 2 months ago (2015-09-24 15:56:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364233002/1
5 years, 2 months ago (2015-09-24 16:01:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-24 17:20:59 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f4d38ea57aa739b525066b095468cb4af1d2799b Cr-Commit-Position: refs/heads/master@{#10060}
5 years, 2 months ago (2015-09-24 17:21:13 UTC) #14
the sun
5 years, 2 months ago (2015-09-25 08:30:48 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1368083002/ by solenberg@webrtc.org.

The reason for reverting is: Breaking Chromium FYI bots..

Powered by Google App Engine
This is Rietveld 408576698