CodecOwner::SetEncoders: Return error code when given bad arguments

CodecOwner::SetEncoders: Return error code when given bad arguments

Instead of FATAL on a bad codec specification, log and return an error
code. This is a band-aid until callers are taught to only give it good
specifications.

BUG=webrtc:5033, chromium:526478
Committed: https://crrev.com/574d5daa6d522a77f19ad7a512023e1476df7039
Cr-Commit-Position: refs/heads/master@{#10066}

[kwiberg-webrtc, 2015-09-24 09:54:46]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kwiberg-webrtc, 2015-09-24 10:00:03]

🐛

[hlundin-webrtc, 2015-09-24 10:26:53]

LG, but:

- Add chromium:526478 to BUG=
- Add a test to codec_owner_unittest.cc to verify that false is returned on some
invalid CodecInst.

[kwiberg-webrtc, 2015-09-24 11:18:21]

On 2015/09/24 10:26:53, hlundin-webrtc wrote:
> LG, but:
> 
> - Add chromium:526478 to BUG=

Done.

> - Add a test to codec_owner_unittest.cc to verify that false is returned on
some
> invalid CodecInst.

Done.

[hlundin-webrtc, 2015-09-24 11:24:03]

Thanks for fixing!
LGTM

https://codereview.webrtc.org/1364193002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc (right):

https://codereview.webrtc.org/1364193002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc:204: static const
char bad_name[] = "Robert'); DROP TABLE Students;";
Bonus points for the xkcd archaeology!

[kwiberg-webrtc, 2015-09-24 11:26:01]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2015-09-24 11:26:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364193002/20001

[commit-bot: I haz the power, 2015-09-24 15:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 15:42:00]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[kwiberg-webrtc, 2015-09-24 20:00:53]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2015-09-24 20:01:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364193002/20001

[commit-bot: I haz the power, 2015-09-24 22:01:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 22:01:33]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[hlundin-webrtc, 2015-09-25 05:53:03]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2015-09-25 05:53:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364193002/20001

[commit-bot: I haz the power, 2015-09-25 05:53:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-25 05:54:08]

Patchset 2 (id:??) landed as
https://crrev.com/574d5daa6d522a77f19ad7a512023e1476df7039
Cr-Commit-Position: refs/heads/master@{#10066}