Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc

Issue 1363573002: Wire up transport sequence number / send time callbacks to webrtc via libjingle. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add missing updated_options Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc b/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc
index 1bf4b1ec3e7df8f03e971f24333b1bcfdd223567..3504ca74786768afd52f3e2153e973a269e2a387 100644
--- a/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc
+++ b/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc
@@ -103,9 +103,9 @@ class TransportFeedbackAdapterTest : public ::testing::Test {
}
// Utility method, to reset arrival_time_ms before adding send time.
- void OnPacketSent(PacketInfo info) {
+ void OnSentPacket(PacketInfo info) {
info.arrival_time_ms = 0;
- adapter_->OnPacketSent(info);
+ adapter_->OnSentPacket(info);
}
SimulatedClock clock_;
@@ -125,7 +125,7 @@ TEST_F(TransportFeedbackAdapterTest, AdaptsFeedbackAndPopulatesSendTimes) {
packets.push_back(PacketInfo(140, 240, 4, 1500, true));
for (const PacketInfo& packet : packets)
- OnPacketSent(packet);
+ OnSentPacket(packet);
rtcp::TransportFeedback feedback;
feedback.WithBase(packets[0].sequence_number,
@@ -160,7 +160,7 @@ TEST_F(TransportFeedbackAdapterTest, HandlesDroppedPackets) {
for (const PacketInfo& packet : packets) {
if (packet.sequence_number >= kSendSideDropBefore)
- OnPacketSent(packet);
+ OnSentPacket(packet);
}
rtcp::TransportFeedback feedback;
@@ -199,7 +199,7 @@ TEST_F(TransportFeedbackAdapterTest, SendTimeWrapsBothWays) {
packets.push_back(PacketInfo(kHighArrivalTimeMs, 220, 2, 1500, true));
for (const PacketInfo& packet : packets)
- OnPacketSent(packet);
+ OnSentPacket(packet);
for (size_t i = 0; i < packets.size(); ++i) {
rtc::scoped_ptr<rtcp::TransportFeedback> feedback(
@@ -263,8 +263,8 @@ TEST_F(TransportFeedbackAdapterTest, TimestampDeltas) {
// Packets will be added to send history.
for (const PacketInfo& packet : sent_packets)
- OnPacketSent(packet);
- OnPacketSent(info);
+ OnSentPacket(packet);
+ OnSentPacket(info);
// Create expected feedback and send into adapter.
rtc::scoped_ptr<rtcp::TransportFeedback> feedback(

Powered by Google App Engine
This is Rietveld 408576698