Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: talk/media/webrtc/webrtcvideoengine2_unittest.cc

Issue 1363573002: Wire up transport sequence number / send time callbacks to webrtc via libjingle. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/webrtc/webrtcvideoengine2_unittest.cc
diff --git a/talk/media/webrtc/webrtcvideoengine2_unittest.cc b/talk/media/webrtc/webrtcvideoengine2_unittest.cc
index 247ba96a193e4ffc70600d9e643bd3e385643c5a..52d2b5246f2c79a466e95d7bb12c1d4348f77703 100644
--- a/talk/media/webrtc/webrtcvideoengine2_unittest.cc
+++ b/talk/media/webrtc/webrtcvideoengine2_unittest.cc
@@ -258,6 +258,19 @@ TEST_F(WebRtcVideoEngine2Test, SupportsAbsoluteSenderTimeHeaderExtension) {
FAIL() << "Absolute Sender Time extension not in header-extension list.";
}
+TEST_F(WebRtcVideoEngine2Test, SupportsTransportSequenceNumberHeaderExtension) {
+ std::vector<RtpHeaderExtension> extensions = engine_.rtp_header_extensions();
+ ASSERT_FALSE(extensions.empty());
+ for (size_t i = 0; i < extensions.size(); ++i) {
+ if (extensions[i].uri == kRtpTransportSequenceNumberHeaderExtension) {
+ EXPECT_EQ(kRtpTransportSequenceNumberHeaderExtensionDefaultId,
+ extensions[i].id);
+ return;
+ }
+ }
+ FAIL() << "Transport sequence number extension not in header-extension list.";
+}
+
TEST_F(WebRtcVideoEngine2Test, SupportsVideoRotationHeaderExtension) {
std::vector<RtpHeaderExtension> extensions = engine_.rtp_header_extensions();
ASSERT_FALSE(extensions.empty());
@@ -1176,6 +1189,18 @@ TEST_F(WebRtcVideoChannel2Test, RecvAbsoluteSendTimeHeaderExtensions) {
webrtc::RtpExtension::kAbsSendTime);
}
+// Test support for transport sequence number header extension.
+TEST_F(WebRtcVideoChannel2Test, SendTransportSequenceNumberHeaderExtensions) {
+ TestSetSendRtpHeaderExtensions(
+ kRtpTransportSequenceNumberHeaderExtension,
+ webrtc::RtpExtension::kTransportSequenceNumber);
+}
+TEST_F(WebRtcVideoChannel2Test, RecvTransportSequenceNumberHeaderExtensions) {
+ TestSetRecvRtpHeaderExtensions(
+ kRtpTransportSequenceNumberHeaderExtension,
+ webrtc::RtpExtension::kTransportSequenceNumber);
+}
+
// Test support for video rotation header extension.
TEST_F(WebRtcVideoChannel2Test, SendVideoRotationHeaderExtensions) {
TestSetSendRtpHeaderExtensions(kRtpVideoRotationHeaderExtension,
@@ -2307,6 +2332,26 @@ TEST_F(WebRtcVideoChannel2Test, TestSetDscpOptions) {
channel_->SetInterface(NULL);
}
+TEST_F(WebRtcVideoChannel2Test, OnSentPacketPropagatesToCall) {
+ webrtc::SentPacket packet = fake_call_->last_packet_sent();
+ EXPECT_EQ(-1, packet.transport_sequence_number);
+ EXPECT_EQ(-1, packet.send_time_ms);
+
+ rtc::SentPacket rtc_sent(1, 1234);
+ channel_->OnPacketSent(rtc_sent);
+ packet = fake_call_->last_packet_sent();
+ EXPECT_EQ(rtc_sent.transport_sequence_number,
+ packet.transport_sequence_number);
+ EXPECT_EQ(rtc_sent.send_time_ms, packet.send_time_ms);
+
+ rtc::SentPacket rtc_sent2(2, 1244);
+ channel_->OnPacketSent(rtc_sent2);
+ packet = fake_call_->last_packet_sent();
+ EXPECT_EQ(rtc_sent2.transport_sequence_number,
+ packet.transport_sequence_number);
+ EXPECT_EQ(rtc_sent2.send_time_ms, packet.send_time_ms);
+}
+
TEST_F(WebRtcVideoChannel2Test, OnReadyToSendSignalsNetworkState) {
EXPECT_EQ(webrtc::kNetworkUp, fake_call_->GetNetworkState());

Powered by Google App Engine
This is Rietveld 408576698