Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: talk/app/webrtc/mediacontroller.cc

Issue 1363573002: Wire up transport sequence number / send time callbacks to webrtc via libjingle. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Connect to SignalSentPacket when enabling bundle. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2015 Google Inc. 3 * Copyright 2015 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 11 matching lines...) Expand all
22 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, 22 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR 23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF 24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26 */ 26 */
27 27
28 #include "talk/app/webrtc/mediacontroller.h" 28 #include "talk/app/webrtc/mediacontroller.h"
29 29
30 #include "webrtc/base/bind.h" 30 #include "webrtc/base/bind.h"
31 #include "webrtc/base/checks.h" 31 #include "webrtc/base/checks.h"
32 #include "webrtc/call.h"
33 32
34 namespace { 33 namespace {
35 34
36 const int kMinBandwidthBps = 30000; 35 const int kMinBandwidthBps = 30000;
37 const int kStartBandwidthBps = 300000; 36 const int kStartBandwidthBps = 300000;
38 const int kMaxBandwidthBps = 2000000; 37 const int kMaxBandwidthBps = 2000000;
39 38
40 class MediaController : public webrtc::MediaControllerInterface { 39 class MediaController : public webrtc::MediaControllerInterface,
40 public sigslot::has_slots<> {
41 public: 41 public:
42 MediaController(rtc::Thread* worker_thread, 42 MediaController(webrtc::CallFactory* call_factory,
43 rtc::Thread* worker_thread,
43 webrtc::VoiceEngine* voice_engine) 44 webrtc::VoiceEngine* voice_engine)
44 : worker_thread_(worker_thread) { 45 : worker_thread_(worker_thread), call_factory_(call_factory) {
45 RTC_DCHECK(nullptr != worker_thread); 46 RTC_DCHECK(nullptr != worker_thread);
46 worker_thread_->Invoke<void>( 47 worker_thread_->Invoke<void>(
47 rtc::Bind(&MediaController::Construct_w, this, voice_engine)); 48 rtc::Bind(&MediaController::Construct_w, this, voice_engine));
48 } 49 }
49 ~MediaController() override { 50 ~MediaController() override {
50 worker_thread_->Invoke<void>( 51 worker_thread_->Invoke<void>(
51 rtc::Bind(&MediaController::Destruct_w, this)); 52 rtc::Bind(&MediaController::Destruct_w, this));
52 } 53 }
53 54
54 webrtc::Call* call_w() override { 55 webrtc::Call* call_w() override {
55 RTC_DCHECK(worker_thread_->IsCurrent()); 56 RTC_DCHECK(worker_thread_->IsCurrent());
56 return call_.get(); 57 return call_.get();
57 } 58 }
58 59
59 private: 60 private:
60 void Construct_w(webrtc::VoiceEngine* voice_engine) { 61 void Construct_w(webrtc::VoiceEngine* voice_engine) {
61 RTC_DCHECK(worker_thread_->IsCurrent()); 62 RTC_DCHECK(worker_thread_->IsCurrent());
62 webrtc::Call::Config config; 63 webrtc::Call::Config config;
63 config.voice_engine = voice_engine; 64 config.voice_engine = voice_engine;
64 config.bitrate_config.min_bitrate_bps = kMinBandwidthBps; 65 config.bitrate_config.min_bitrate_bps = kMinBandwidthBps;
65 config.bitrate_config.start_bitrate_bps = kStartBandwidthBps; 66 config.bitrate_config.start_bitrate_bps = kStartBandwidthBps;
66 config.bitrate_config.max_bitrate_bps = kMaxBandwidthBps; 67 config.bitrate_config.max_bitrate_bps = kMaxBandwidthBps;
67 call_.reset(webrtc::Call::Create(config)); 68 call_.reset(call_factory_->CreateCall(config));
68 } 69 }
69 void Destruct_w() { 70 void Destruct_w() {
70 RTC_DCHECK(worker_thread_->IsCurrent()); 71 RTC_DCHECK(worker_thread_->IsCurrent());
71 call_.reset(nullptr); 72 call_.reset();
72 } 73 }
73 74
74 rtc::Thread* worker_thread_; 75 rtc::Thread* const worker_thread_;
76 webrtc::CallFactory* call_factory_;
75 rtc::scoped_ptr<webrtc::Call> call_; 77 rtc::scoped_ptr<webrtc::Call> call_;
78 std::set<cricket::TransportChannel*> transport_channels_;
pthatcher1 2015/10/09 20:57:48 You don't need this any more, do you?
stefan-webrtc 2015/10/10 15:32:51 Done.
76 79
77 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(MediaController); 80 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(MediaController);
78 }; 81 };
79 } // namespace { 82 } // namespace {
80 83
81 namespace webrtc { 84 namespace webrtc {
82 85
83 MediaControllerInterface* MediaControllerInterface::Create( 86 MediaControllerInterface* MediaControllerInterface::Create(
84 rtc::Thread* worker_thread, webrtc::VoiceEngine* voice_engine) { 87 webrtc::CallFactory* call_factory,
85 return new MediaController(worker_thread, voice_engine); 88 rtc::Thread* worker_thread,
89 webrtc::VoiceEngine* voice_engine) {
90 return new MediaController(call_factory, worker_thread, voice_engine);
86 } 91 }
87 } // namespace webrtc 92 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698