Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: talk/app/webrtc/mediacontroller.cc

Issue 1363573002: Wire up transport sequence number / send time callbacks to webrtc via libjingle. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Cleanups. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2015 Google Inc. 3 * Copyright 2015 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 12 matching lines...) Expand all
23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR 23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF 24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26 */ 26 */
27 27
28 #include "talk/app/webrtc/mediacontroller.h" 28 #include "talk/app/webrtc/mediacontroller.h"
29 29
30 #include "webrtc/base/bind.h" 30 #include "webrtc/base/bind.h"
31 #include "webrtc/base/checks.h" 31 #include "webrtc/base/checks.h"
32 #include "webrtc/call.h" 32 #include "webrtc/call.h"
33 #include "webrtc/p2p/base/transportchannel.h"
33 34
34 namespace { 35 namespace {
35 36
36 const int kMinBandwidthBps = 30000; 37 const int kMinBandwidthBps = 30000;
37 const int kStartBandwidthBps = 300000; 38 const int kStartBandwidthBps = 300000;
38 const int kMaxBandwidthBps = 2000000; 39 const int kMaxBandwidthBps = 2000000;
39 40
40 class MediaController : public webrtc::MediaControllerInterface { 41 class MediaController : public webrtc::MediaControllerInterface,
42 public sigslot::has_slots<> {
41 public: 43 public:
42 MediaController(rtc::Thread* worker_thread, 44 MediaController(rtc::Thread* worker_thread,
43 webrtc::VoiceEngine* voice_engine) 45 webrtc::VoiceEngine* voice_engine)
44 : worker_thread_(worker_thread) { 46 : worker_thread_(worker_thread) {
45 RTC_DCHECK(nullptr != worker_thread); 47 RTC_DCHECK(nullptr != worker_thread);
46 worker_thread_->Invoke<void>( 48 worker_thread_->Invoke<void>(
47 rtc::Bind(&MediaController::Construct_w, this, voice_engine)); 49 rtc::Bind(&MediaController::Construct_w, this, voice_engine));
48 } 50 }
49 ~MediaController() override { 51 ~MediaController() override {
50 worker_thread_->Invoke<void>( 52 worker_thread_->Invoke<void>(
51 rtc::Bind(&MediaController::Destruct_w, this)); 53 rtc::Bind(&MediaController::Destruct_w, this));
54 RTC_DCHECK(transport_channels_.empty());
52 } 55 }
53 56
54 webrtc::Call* call_w() override { 57 webrtc::Call* call_w() override {
55 RTC_DCHECK(worker_thread_->IsCurrent()); 58 RTC_DCHECK(worker_thread_->IsCurrent());
56 return call_.get(); 59 return call_.get();
57 } 60 }
58 61
62 void ConnectTransportChannel(
63 cricket::TransportChannel* transport_channel) override {
pthatcher1 2015/10/07 16:44:37 Needs a RTC_DCHECK(worker_thread_->IsCurrent());
stefan-webrtc 2015/10/08 12:53:45 Done.
64 if (transport_channels_.find(transport_channel) !=
65 transport_channels_.end())
66 return;
67 transport_channels_.insert(transport_channel);
68 transport_channel->SignalSentPacket.connect(this,
69 &MediaController::OnSentPacket);
70 }
pthatcher1 2015/10/07 16:44:37 Can't you do this? if (!transport_channels_.inser
stefan-webrtc 2015/10/08 12:53:45 Done.
71
72 void DisconnectTransportChannel(
73 cricket::TransportChannel* transport_channel) override {
74 RTC_DCHECK(transport_channels_.find(transport_channel) !=
75 transport_channels_.end());
76 transport_channels_.erase(transport_channel);
77 transport_channel->SignalSentPacket.disconnect(this);
78 }
79
59 private: 80 private:
60 void Construct_w(webrtc::VoiceEngine* voice_engine) { 81 void Construct_w(webrtc::VoiceEngine* voice_engine) {
61 RTC_DCHECK(worker_thread_->IsCurrent()); 82 RTC_DCHECK(worker_thread_->IsCurrent());
62 webrtc::Call::Config config; 83 webrtc::Call::Config config;
63 config.voice_engine = voice_engine; 84 config.voice_engine = voice_engine;
64 config.bitrate_config.min_bitrate_bps = kMinBandwidthBps; 85 config.bitrate_config.min_bitrate_bps = kMinBandwidthBps;
65 config.bitrate_config.start_bitrate_bps = kStartBandwidthBps; 86 config.bitrate_config.start_bitrate_bps = kStartBandwidthBps;
66 config.bitrate_config.max_bitrate_bps = kMaxBandwidthBps; 87 config.bitrate_config.max_bitrate_bps = kMaxBandwidthBps;
67 call_.reset(webrtc::Call::Create(config)); 88 call_.reset(webrtc::Call::Create(config));
68 } 89 }
69 void Destruct_w() { 90 void Destruct_w() {
70 RTC_DCHECK(worker_thread_->IsCurrent()); 91 RTC_DCHECK(worker_thread_->IsCurrent());
71 call_.reset(nullptr); 92 call_.reset(nullptr);
72 } 93 }
94 void OnSentPacket(cricket::TransportChannel* channel,
95 const rtc::SentPacket& sent_packet) {
96 call_->OnSentPacket(sent_packet);
97 }
73 98
74 rtc::Thread* worker_thread_; 99 rtc::Thread* worker_thread_;
75 rtc::scoped_ptr<webrtc::Call> call_; 100 rtc::scoped_ptr<webrtc::Call> call_;
101 std::set<cricket::TransportChannel*> transport_channels_;
76 102
77 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(MediaController); 103 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(MediaController);
78 }; 104 };
79 } // namespace { 105 } // namespace {
80 106
81 namespace webrtc { 107 namespace webrtc {
82 108
83 MediaControllerInterface* MediaControllerInterface::Create( 109 MediaControllerInterface* MediaControllerInterface::Create(
84 rtc::Thread* worker_thread, webrtc::VoiceEngine* voice_engine) { 110 rtc::Thread* worker_thread, webrtc::VoiceEngine* voice_engine) {
85 return new MediaController(worker_thread, voice_engine); 111 return new MediaController(worker_thread, voice_engine);
86 } 112 }
87 } // namespace webrtc 113 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698