Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1363543002: IntKeyTypeFamilyToKeyType (Closed)

Created:
5 years, 3 months ago by hbos
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

sslidentity.cc/IntKeyTypeFamilyToKeyType function added, converting from int to KeyType. Added to prevent Chromium from breaking if KeyType (now an enum) starts being used in Chromium before KeyType changes to a parameterizable class. When enum -> class change happens, IntKeyTypeFamilyToKeyType will be updated at the same time. Once Chromium starts using class KeyType with parameters this function can be removed. R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/9b5476de9aa2326e7be10c251babe342c91f4a80

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M webrtc/base/sslidentity.h View 1 chunk +8 lines, -3 lines 0 comments Download
M webrtc/base/sslidentity.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hbos
PTAL torbjorng, tommi.
5 years, 3 months ago (2015-09-22 10:01:01 UTC) #3
tommi
lgtm
5 years, 3 months ago (2015-09-22 10:57:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363543002/20001
5 years, 3 months ago (2015-09-22 11:01:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/6692)
5 years, 3 months ago (2015-09-22 12:02:09 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9b5476de9aa2326e7be10c251babe342c91f4a80 Cr-Commit-Position: refs/heads/master@{#10013}
5 years, 3 months ago (2015-09-22 12:13:29 UTC) #9
hbos
5 years, 3 months ago (2015-09-22 12:13:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
9b5476de9aa2326e7be10c251babe342c91f4a80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698