Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1363303002: VideoCapturerAndroidTest: Dispose PeerConnectionFactory with pending frames (Closed)

Created:
5 years, 3 months ago by magjed_webrtc
Modified:
5 years, 3 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroidTest: Dispose PeerConnectionFactory with pending frames Partial revert of change in testReturnBufferLateEndToEnd from https://codereview.webrtc.org/1350863002/. It is ok to dispose PeerConnectionFactory with pending frames after all. BUG=webrtc:4909 R=perkj@webrtc.org Committed: https://crrev.com/2efe58b1892e6f169cdd3ed8426959868ef5497d Cr-Commit-Position: refs/heads/master@{#10049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 3 months ago (2015-09-24 09:42:39 UTC) #2
perkj_webrtc
lgtm
5 years, 3 months ago (2015-09-24 09:44:04 UTC) #3
magjed_webrtc
Committed patchset #1 (id:1) manually as 2efe58b1892e6f169cdd3ed8426959868ef5497d (presubmit successful).
5 years, 3 months ago (2015-09-24 12:16:45 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 12:16:45 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2efe58b1892e6f169cdd3ed8426959868ef5497d
Cr-Commit-Position: refs/heads/master@{#10049}

Powered by Google App Engine
This is Rietveld 408576698