Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1362923002: Revert of Wire up send-side bandwidth estimation. (Closed)

Created:
5 years, 3 months ago by sprang_webrtc
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Wire up send-side bandwidth estimation. (patchset #8 id:140001 of https://codereview.webrtc.org/1338203003/ ) Reason for revert: Breaking some Android bots. https://chromegw.corp.google.com/i/client.webrtc/builders/Android32%20Tests%20%28L%20Nexus5%29 Original issue's description: > Wire up send-side bandwidth estimation. > > BUG=webrtc:4173 > > Committed: https://crrev.com/ef165eefc79cf28bb67779afe303cc2365885547 > Cr-Commit-Position: refs/heads/master@{#10012} TBR=stefan@webrtc.org, kjellander@webrtc.org NOPRESUBMIT=false NOTREECHECKS=false NOTRY=false BUG=webrtc:4173 Committed: https://chromium.googlesource.com/external/webrtc/+/c9bbeb03542cffc14b7d306e5f88b6c0e593864d

Patch Set 1 #

Patch Set 2 : Manual merge of revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -428 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 4 chunks +0 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 9 chunks +3 lines, -48 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 12 chunks +16 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.h View 1 4 chunks +0 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.cc View 1 12 chunks +34 lines, -46 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 chunks +0 lines, -63 lines 0 comments Download
M webrtc/video/rampup_tests.h View 1 4 chunks +0 lines, -6 lines 0 comments Download
M webrtc/video/rampup_tests.cc View 1 8 chunks +0 lines, -94 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 1 2 chunks +13 lines, -8 lines 0 comments Download
M webrtc/video/video_loopback.cc View 1 2 chunks +13 lines, -9 lines 0 comments Download
M webrtc/video/video_quality_test.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_channel_group.h View 1 4 chunks +5 lines, -12 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 1 9 chunks +15 lines, -65 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sprang_webrtc
Created Revert of Wire up send-side bandwidth estimation.
5 years, 3 months ago (2015-09-23 11:09:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362923002/1
5 years, 3 months ago (2015-09-23 11:09:28 UTC) #2
commit-bot: I haz the power
Failed to apply patch for webrtc/video/video_send_stream.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 3 months ago (2015-09-23 11:09:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362923002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362923002/300001
5 years, 3 months ago (2015-09-23 11:37:13 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c9bbeb03542cffc14b7d306e5f88b6c0e593864d Cr-Commit-Position: refs/heads/master@{#10029}
5 years, 3 months ago (2015-09-23 11:52:07 UTC) #10
sprang_webrtc
5 years, 3 months ago (2015-09-23 11:52:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:300001) manually as
c9bbeb03542cffc14b7d306e5f88b6c0e593864d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698