Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: talk/media/base/mediachannel.h

Issue 1362913004: Remove unused SignalMediaError and infrastructure. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: more Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/base/mediachannel.h
diff --git a/talk/media/base/mediachannel.h b/talk/media/base/mediachannel.h
index 9c9e8c4b294f6d060e8c35a3d38b79c456c52fa3..fb9a7f87446defbd309d5e795c19b5dad9913b56 100644
--- a/talk/media/base/mediachannel.h
+++ b/talk/media/base/mediachannel.h
@@ -1096,16 +1096,6 @@ class VoiceMediaChannel : public MediaChannel {
virtual bool InsertDtmf(uint32 ssrc, int event, int duration, int flags) = 0;
// Gets quality stats for the channel.
virtual bool GetStats(VoiceMediaInfo* info) = 0;
- // Gets last reported error for this media channel.
- virtual void GetLastMediaError(uint32* ssrc,
- VoiceMediaChannel::Error* error) {
- ASSERT(error != NULL);
- *error = ERROR_NONE;
- }
-
- // Signal errors from MediaChannel. Arguments are:
- // ssrc(uint32), and error(VoiceMediaChannel::Error).
- sigslot::signal2<uint32, VoiceMediaChannel::Error> SignalMediaError;
};
struct VideoSendParameters : RtpSendParameters<VideoCodec, VideoOptions> {
@@ -1159,10 +1149,6 @@ class VideoMediaChannel : public MediaChannel {
virtual bool RequestIntraFrame() = 0;
virtual void UpdateAspectRatio(int ratio_w, int ratio_h) = 0;
- // Signal errors from MediaChannel. Arguments are:
- // ssrc(uint32), and error(VideoMediaChannel::Error).
- sigslot::signal2<uint32, Error> SignalMediaError;
-
protected:
VideoRenderer *renderer_;
};
@@ -1285,9 +1271,6 @@ class DataMediaChannel : public MediaChannel {
sigslot::signal3<const ReceiveDataParams&,
const char*,
size_t> SignalDataReceived;
- // Signal errors from MediaChannel. Arguments are:
- // ssrc(uint32), and error(DataMediaChannel::Error).
- sigslot::signal2<uint32, DataMediaChannel::Error> SignalMediaError;
// Signal when the media channel is ready to send the stream. Arguments are:
// writable(bool)
sigslot::signal1<bool> SignalReadyToSend;

Powered by Google App Engine
This is Rietveld 408576698