webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc - Issue 1362503003: Use suffixed {uint,int}{8,16,32,64}_t types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc

Issue 1362503003: Use suffixed {uint,int}{8,16,32,64}_t types. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: henrikg feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc

index 43a7de0458aae6e31d4b9536a686c649a026624a..caca96d3d81489e08c97a116fc893c12a26a5b9f 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc

+++ b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc

@@ -123,7 +123,7 @@ bool H264CMSampleBufferToAnnexBBuffer(

// Read the length of the next packet of data. Must convert from big endian

// to host endian.

RTC_DCHECK_GE(bytes_remaining, (size_t)nalu_header_size);

- uint32_t* uint32_data_ptr = reinterpret_cast<uint32*>(data_ptr);

+ uint32_t* uint32_data_ptr = reinterpret_cast<uint32_t*>(data_ptr);

uint32_t packet_size = CFSwapInt32BigToHost(*uint32_data_ptr);

// Update buffer.

annexb_buffer->AppendData(kAnnexBHeaderBytes, sizeof(kAnnexBHeaderBytes));