webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h - Issue 1362503003: Use suffixed {uint,int}{8,16,32,64}_t types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h

Issue 1362503003: Use suffixed {uint,int}{8,16,32,64}_t types. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase + revert basictypes.h (to be landed separately just in case of a revert due to unexpected us… Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h

diff --git a/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h b/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h

index f1a069d831408a28c3f20357d80f8d57a70c52c8..672fa3aa8911ac873708689299ed9a65972e976e 100644

--- a/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h

+++ b/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h

@@ -848,7 +848,7 @@ class TestVp8Simulcast : public ::testing::Test {

// 3rd stream: -1, -1, -1, -1, ....

// Regarding the 3rd stream, note that a stream/encoder with 1 temporal layer

// should always have temporal layer idx set to kNoTemporalIdx = -1.

- // Since CodecSpecificInfoVP8.temporalIdx is uint8, this will wrap to 255.

+ // Since CodecSpecificInfoVP8.temporalIdx is uint8_t, this will wrap to 255.

// TODO(marpan): Although this seems safe for now, we should fix this.

void TestSpatioTemporalLayers321PatternEncoder() {

int temporal_layer_profile[3] = {3, 2, 1};