Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1361923004: Autoroll: Update checkout before reading chromium_revision. (Closed)

Created:
5 years, 3 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Autoroll: Update checkout before reading chromium_revision. Ensure the checkout is updated _before_ reading the current revision from the DEPS file. This will avoid errors when a checkout is not up to date, as updating happened after reading the revision before this change. BUG=webrtc:4688 R=phoglund@webrtc.org Committed: https://crrev.com/44d5d7ba42d5d595b58a1f7767d50570d4ae5791 Cr-Commit-Position: refs/heads/master@{#10071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/autoroller/roll_chromium_revision.py View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_webrtc
5 years, 3 months ago (2015-09-24 11:38:28 UTC) #2
phoglund
lgtm
5 years, 2 months ago (2015-09-25 10:36:03 UTC) #3
kjellander_webrtc
Committed patchset #1 (id:1) manually as 44d5d7ba42d5d595b58a1f7767d50570d4ae5791 (presubmit successful).
5 years, 2 months ago (2015-09-25 11:22:03 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 11:22:06 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44d5d7ba42d5d595b58a1f7767d50570d4ae5791
Cr-Commit-Position: refs/heads/master@{#10071}

Powered by Google App Engine
This is Rietveld 408576698